Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change password - Developer Portal #231

Closed
HollyJoyPhillips opened this issue Feb 11, 2020 · 3 comments · Fixed by #265 or #285
Closed

Unable to change password - Developer Portal #231

HollyJoyPhillips opened this issue Feb 11, 2020 · 3 comments · Fixed by #265 or #285
Assignees
Labels
bug Something isn't working front-end Relates to front end issues marketplace Relates to the Marketplace

Comments

@HollyJoyPhillips
Copy link
Contributor

HollyJoyPhillips commented Feb 11, 2020

Summary: An error occurs when trying to change password when logged in as a Developer

Location: https://dev.marketplace.reapit.cloud/developer/settings

Current Behaviour: Logged in as '[email protected]' > settings > change password > following error occurs:

{__type: "ResourceNotFoundException", message: "User pool client cognitoClientId does not exist."}
__type: "ResourceNotFoundException"
message: "User pool client cognitoClientId does not exist."

Expected Behaviour: Change password, get logged out and routed back to login screen with notification ' Password changed successfully'

@HollyJoyPhillips HollyJoyPhillips added bug Something isn't working marketplace Relates to the Marketplace front-end Relates to front end issues labels Feb 11, 2020
@duong-se duong-se self-assigned this Feb 13, 2020
duong-se added a commit that referenced this issue Feb 13, 2020
Replace the string 'coggnitoClientId' with the actual env in saga
willmcvay pushed a commit that referenced this issue Feb 13, 2020
Replace the string 'coggnitoClientId' with the actual env in saga
@HollyJoyPhillips
Copy link
Contributor Author

@tanphamhaiduong The change password is now working but the message confirming the changes have been successful are showing in the developer portal and not on the login screen. It's not a problem to show the toast in the portal on the 'settings' page but because the developer gets logged out it happens too quickly.

When the developer has been automatically logged out, the message should show on the login screen 'Password Changed Successfully'. Thanks.

@duong-se
Copy link
Contributor

duong-se commented Feb 14, 2020

Hi @willmcvay, there is a problem with trying to show message in the login screen, previously back then when we didn't have the OAuth flow in between authentication process the logout would just be to redirect user to the login page with the additional query (something like 'isPasswordChanged') to be able to show the message. However, with the new flow right now, when logout user will be redirected todev.connect.reapit.cloud/logout and then to the login page via the redirect_uri param, and since this uri cannot have query string (source) and the state param is for LoginType already => the old approach is not working any more

One possible solution is to add another developer login route, e.g something like developer/login/:passwordchanged and we will extract the path variable in the login page. This requires you to add the specified route at your end too so that everything work as expected.

Feel free to give your opinion on this.

@willmcvay
Copy link
Contributor

So there is a variable called ‘STATE’ which is an arbitrary string of comma separate values that OAuth supports. See the urls on Marketplace currently, this is how we manage loginType. It’s a bit gross but it works. Otherwise, local storage??

phmngocnghia pushed a commit that referenced this issue Feb 14, 2020
Replace the string 'coggnitoClientId' with the actual env in saga
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
[CLD-636]implement submit app happy path test case
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
fix: info text when empty developer
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
Replace the string 'coggnitoClientId' with the actual env in saga
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
3 participants