Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #131 migrate elements github page #181

Merged
merged 3 commits into from
Feb 6, 2020
Merged

chore: #131 migrate elements github page #181

merged 3 commits into from
Feb 6, 2020

Conversation

trankhacvy
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the elements Relates to Elements components and utilities label Feb 5, 2020
willmcvay
willmcvay approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

duong-se
duong-se reviewed Feb 6, 2020
View reviewed changes
.github/workflows/release-develop.yml Outdated
@@ -68,3 +68,54 @@ jobs:
- name: Release Develop
run: |
yarn release:dev --since origin/master^1 --parallel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to add particular CI for only elements
we can use
at elements package.json

"scripts": {
  "release:dev": "gh-pages -d dist"
}
``

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were only releasing to Pages when we release to NPM?

duong-se
duong-se reviewed Feb 6, 2020
View reviewed changes
packages/elements/package.json Outdated
@@ -20,6 +20,7 @@
"module": "dist/elements.esm.js",
"typings": "dist/index.d.ts",
"scripts": {
"build-storybook": "build-storybook -o out",
Copy link
Contributor

@duong-se duong-se Feb 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

"release:dev": "gh-pages -d dist"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then add gh-pages to dev dependencies

@trankhacvy trankhacvy force-pushed the chore/issue-131-migrate-elements-github-page branch from 4a4d0e3 to a8261e0 Compare February 6, 2020 10:07
duong-se
duong-se reviewed Feb 6, 2020
View reviewed changes
.github/workflows/release-develop.yml Outdated
- name: Release Develop
run: |
yarn release:dev --since origin/master^1 --parallel
yarn release:dev --since origin/master^1 --parallel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add more line for EOF

@trankhacvy trankhacvy force-pushed the chore/issue-131-migrate-elements-github-page branch from a8261e0 to eb0f071 Compare February 6, 2020 10:21
@github-actions github-actions bot requested a review from duong-se February 6, 2020 10:21
@trankhacvy trankhacvy force-pushed the chore/issue-131-migrate-elements-github-page branch 3 times, most recently from 8703fcc to a6126d2 Compare February 6, 2020 10:44
willmcvay
willmcvay approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

duong-se
duong-se approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trankhacvy trankhacvy force-pushed the chore/issue-131-migrate-elements-github-page branch from a6126d2 to 951ee63 Compare February 6, 2020 12:58
@trankhacvy trankhacvy force-pushed the chore/issue-131-migrate-elements-github-page branch from 951ee63 to 072b151 Compare February 6, 2020 13:10
@trankhacvy trankhacvy merged commit 16d5842 into master Feb 6, 2020
@trankhacvy trankhacvy deleted the chore/issue-131-migrate-elements-github-page branch February 6, 2020 13:18
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@vuhuucuong
[CLD-406] Fix scroll to link in Docs (Dev portals) (#181)
e527623 
* [CLD-406] Fix scroll to link in Docs (Dev portals), scroll to anchor link when directly go into route that have `#`

* Remove unnecessary links

* Update snapshot

* Add tests
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@dannd4
Merge pull request #181 from reapit/feature/cld-566-create-help-guide…
0a0e505 
…-wizard

[CLD-566] create help guide wizard
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@trankhacvy
chore: #131 migrate elements github page (#181)
64c4727 
* chore: #131 migrate elements github page

* chore: #131 update deploy github page command

* chore: #131 add more space
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannd4 dannd4 Awaiting requested review from dannd4

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@zlatanpham zlatanpham Awaiting requested review from zlatanpham

@duong-se duong-se Awaiting requested review from duong-se

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@trankhacvy trankhacvy

Labels
elements Relates to Elements components and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trankhacvy @willmcvay @duong-se