Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Github Pages deployment of elements should be migrated to Foundations #131

Closed
willmcvay opened this issue Jan 29, 2020 · 1 comment
Closed
Assignees
Labels
chore Maintenance or housekeeping tasks elements Relates to Elements components and utilities front-end Relates to front end issues

Comments

@willmcvay
Copy link
Contributor

  • Currently the elements project is being deployed from the old elements repo to Github Pages. This should be migrated across to Foundations and the old repo archived.
  • This should be part of the release:prod workflow if Elements is manually released to prod and has changed see There should be a release:prod workflow #119
@willmcvay willmcvay added chore Maintenance or housekeeping tasks elements Relates to Elements components and utilities labels Jan 29, 2020
@trankhacvy trankhacvy self-assigned this Feb 4, 2020
@trankhacvy
Copy link
Contributor

Hey @willmcvay, this is my solution for this issue but I'm not sure it's good way. Could you please review it and give your comment ?

In release-production.yml, we add:

  deploy_story_book:
    runs-on: ubuntu-latest
    needs: setup
    steps:
      - name: checks out repository to $GITHUB_WORKSPACE
        uses: actions/checkout@v1

      - name: Setup Node Environement
        uses: actions/setup-node@v1
        with:
          node-version: 12

      - name: Get installed node_modules
        id: cache
        uses: actions/cache@v1
        with:
          path: node_modules
          key: build-${{ hashFiles('**/yarn.lock') }}
          restore-keys: |
            build-${{ hashFiles('**/yarn.lock') }}
      - name: build story book
        run: yarn build-storybook

      - name: deploy story book to GH pages
        uses: JamesIves/github-pages-deploy-action@releases/v3
        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          BASE_BRANCH: master # The branch the action should deploy from.
          BRANCH: gh-pages # The branch the action should deploy to.
          FOLDER: out # The folder the action should deploy.

And then in root package.json and package.json of elements package we add
"build-storybook": "build-storybook -o out"
script to build storybook.

trankhacvy added a commit that referenced this issue Feb 6, 2020
trankhacvy added a commit that referenced this issue Feb 6, 2020
trankhacvy added a commit that referenced this issue Feb 6, 2020
* chore: #131 migrate elements github page

* chore: #131 update deploy github page command

* chore: #131 add more space
@HollyJoyPhillips HollyJoyPhillips added the front-end Relates to front end issues label Feb 10, 2020
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
* chore: #131 migrate elements github page

* chore: #131 update deploy github page command

* chore: #131 add more space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance or housekeeping tasks elements Relates to Elements components and utilities front-end Relates to front end issues
Projects
None yet
Development

No branches or pull requests

3 participants