Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #105 fixed ipad ui developer welcome #147

Merged
merged 4 commits into from
Feb 1, 2020
Merged

fix: #105 fixed ipad ui developer welcome #147

merged 4 commits into from
Feb 1, 2020

Conversation

dannd4
Copy link
Contributor

@dannd4 dannd4 commented Jan 31, 2020 •
edited
Loading

@github-actions github-actions bot added elements Relates to Elements components and utilities marketplace Relates to the Marketplace labels Jan 31, 2020
duong-se
duong-se reviewed Jan 31, 2020
View reviewed changes
packages/elements/src/components/HelpGuide/index.tsx Outdated
if (isMobileScreen && helpguideRef.current && wrapperStepRef.current) {
const wrapperWidth = helpguideRef.current.clientWidth * total
wrapperStepRef.current.style.width = `${wrapperWidth}px`
if (helpguideRef.current && wrapperStepRef.current) {
Copy link
Contributor

@duong-se duong-se Jan 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if (helpguideRef.current && wrapperStepRef.current && isMobileScreen) {
      const wrapperWidth = helpguideRef.current.clientWidth * total
      wrapperStepRef.current.style.width = `${wrapperWidth}px`
}
if (helpguideRef.current && wrapperStepRef.current && !isMobileScreen) {
      wrapperStepRef.current.style.width = '100%'
}

I think this one will look more cleaner

willmcvay
willmcvay approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from Duong's comment, looks good 👍

@dannd4 dannd4 force-pushed the fix/105-ipad-ui-fixed-for-welcome-developer branch from 30086e0 to 722dc1a Compare February 1, 2020 04:57
duong-se
duong-se approved these changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannd4 dannd4 merged commit 5a0c084 into master Feb 1, 2020
@dannd4 dannd4 deleted the fix/105-ipad-ui-fixed-for-welcome-developer branch February 1, 2020 05:13
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@dannd4
fix: #105 fixed ipad ui developer welcome (#147)
57f46b2 
* fix: #105 fixed ipad ui developer welcome

* fix: #139 fixed ui developer welcome

* fix: #105 fix review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se approved these changes

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@zlatanpham zlatanpham Awaiting requested review from zlatanpham

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@dannd4 dannd4

Labels
elements Relates to Elements components and utilities marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannd4 @willmcvay @duong-se