Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology for OAuth flows is incorrect #252

Closed
cbryanreapit opened this issue Feb 12, 2020 · 4 comments · Fixed by #277
Closed

Terminology for OAuth flows is incorrect #252

cbryanreapit opened this issue Feb 12, 2020 · 4 comments · Fixed by #277
Assignees
Labels
bug Something isn't working front-end Relates to front end issues marketplace Relates to the Marketplace

Comments

@cbryanreapit
Copy link
Contributor

cbryanreapit commented Feb 12, 2020

Developers are required to select the auth flow that their application will use as part of registration process:

image

The terminology for these flows isn't right. OAuth is a well known standard for managing auth so urge that we standardise our UI to present recognisable flow names

User session should be authorization code / Reapit Connect
Client secret should be client credentials

Similar but less important, I think it wouldn't hurt to get the 'scopes' terminology in here. We use 'permissions' at present, which is more user friendly, but scopes is an OAuth concept that indicates to the developer that their bearer token will be responsible for delivering their access via scopes.

See mock up:
image

Please can we hyperlink the 'Reapit Connect' to https://foundations-documentation.reapit.cloud/api/reapit-connect

@cbryanreapit cbryanreapit added bug Something isn't working marketplace Relates to the Marketplace front-end Relates to front end issues labels Feb 12, 2020
@duong-se duong-se self-assigned this Feb 13, 2020
@duong-se
Copy link
Contributor

Similar but less important, I think it wouldn't hurt to get the 'scopes' terminology in here. We use 'permissions' at present, which is more user friendly, but scopes is an OAuth concept that indicates to the developer that their bearer token will be responsible for delivering their access via scopes.

So will we include these edit in this issue also?

@HollyJoyPhillips
Copy link
Contributor

@tanphamhaiduong Regarding your comment above, it's a good point. I'll have a review and come back to you. Let's leave it for the moment as we will need to go back to this section to update the URL for the docs so we can review it then.

Also, as discussed at StandUp, please can you also update the terminology for the app modal when 'Client Credentials' is selected. It should say 'Show Client Credentials' not 'Show Client Secret'. This is only visible in the Developers portal, thank you.
image

@duong-se
Copy link
Contributor

@HollyJoyPhillips Yes, I will do that.

@HollyJoyPhillips
Copy link
Contributor

@tanphamhaiduong Thanks, looks good. Can you add the hyperlink on 'Reapit Connect'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants