Skip to content

Commit

Permalink
fix: #252 correct terminology in developer submit app page
Browse files Browse the repository at this point in the history
  • Loading branch information
duong-se committed Feb 14, 2020
1 parent 6294f77 commit 469791b
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ export const SubmitApp: React.FC<SubmitAppProps> = ({
<FormSubHeading>
This section refers to the listing status in the Marketplace. If your App is an external application
i.e. it is just an API feed app or is a web application that exists out of the Marketplace
ecosystem, please select, &ldquo;Direct API&rdquo; Your app will still need to be listed in the
ecosystem, please select, &ldquo;Direct API&rdquo;. Your app will still need to be listed in the
Marketplace and installed by clients so they can grant permissions however, it will not appear as a
launchable app for users from the Marketplace. It is a hard requirement that launchable apps conform
closely to our &ldquo;Elements&rdquo;, brand guidelines so if your app does not, please also select
Expand All @@ -548,11 +548,11 @@ export const SubmitApp: React.FC<SubmitAppProps> = ({
<FormSubHeading>
Please select an authentication flow for your application.{' '}
<strong>You can only do this once when you submit your app.</strong> You should always select
&ldquo;User Session&rdquo; for client side authenticated apps. In this case, your users will have to
login and you will need to attach a Bearer token to your API Authorization headers. If you select
&ldquo;Client Secret&rdquo; we will provide you with a secret token to include in your API requests.
This secret will be unique per app and would typically be the flow for machine-to-machine server
side apps.{' '}
&ldquo;Authorisation Code&rdquo; for client side authenticated apps. In this case, your users will
have to login and you will need to attach a Bearer token to your API Authorization headers. If you
select &ldquo;Client Credentials&rdquo; we will provide you with a secret token to include in your
API requests. This secret will be unique per app and would typically be the flow for
machine-to-machine server side apps.{' '}
<strong>
It is fundamentally insecure to expose this secret on the client side and doing so will result in
your app being rejected.{' '}
Expand All @@ -570,8 +570,8 @@ export const SubmitApp: React.FC<SubmitAppProps> = ({
state={values['authFlow']}
disabled={!isSubmitApp}
options={[
{ label: 'USER SESSION', value: 'authorisationCode' },
{ label: 'CLIENT SECRET', value: 'clientCredentials' },
{ label: 'Authorisation Code', value: 'authorisationCode' },
{ label: 'Client Credentials', value: 'clientCredentials' },
]}
name="authFlow"
id="authFlow"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`AppAuthenticationDetail should match a snapshot 1`] = `
href="#"
onClick={[Function]}
>
Show Client Secret
Show Client Credentials
</a>
</div>
</Fragment>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const AppAuthenticationDetail: React.FunctionComponent<AppAuthenticationD
<div className={appDetailStyles.appInfoRow}>
<p className={appDetailStyles.appInfoProperty}>Authentication:</p>
<a href="#" onClick={handleShowAuthCode} className={styles.btnShowAuthentication}>
Show Client Secret
Show Client Credentials
</a>
</div>
{loading && <Loader body={false} />}
Expand Down
2 changes: 1 addition & 1 deletion packages/marketplace/src/tests/badges/badge-branches.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/marketplace/src/tests/badges/badge-functions.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/marketplace/src/tests/badges/badge-lines.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 469791b

Please sign in to comment.