-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): upgrade base image to ubuntu 24.04 #99
build(docker): upgrade base image to ubuntu 24.04 #99
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
=========================================
- Coverage 3.78% 3.66% -0.12%
=========================================
Files 6 6
Lines 185 191 +6
=========================================
Hits 7 7
- Misses 178 184 +6 |
It seems like we have some issues after the upgrade. In particular, this workflow fails: Snakefile def get_all_inputs(wildcards):
import os
files = os.listdir("inputs")
full_files = [f"inputs/{file}" for file in files]
return full_files
rule all:
input:
"results/merged.txt"
rule merge:
input:
get_all_inputs
output:
"results/merged.txt"
container:
"docker://docker.io/library/ubuntu:20.04"
shell:
"mkdir results && echo done > {output}" reana.yaml inputs:
directories:
- inputs
files:
- Snakefile
workflow:
type: snakemake
file: Snakefile File structure (input files are empty) $ tree
.
├── inputs
│ ├── a.txt
│ ├── b.txt
│ └── c.txt
├── reana.yaml
└── Snakefile
2 directories, 5 files Error reported by REANA
For some reason, the files have whitespaces in their filename, we can have a look together Edit: see also snakemake/snakemake#2480 |
f8413d1
to
0487b81
Compare
0487b81
to
3f034f0
Compare
8cca02c
to
b265591
Compare
b265591
to
7811bd0
Compare
7811bd0
to
4fec792
Compare
4fec792
to
d85ff2e
Compare
d85ff2e
to
6aae67f
Compare
Closes reanahub/reana#808
Old PR: #98