fix(docker): explicitly specify shell (#598) #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 74.28% 74.28%
=======================================
Files 15 15
Lines 1466 1466
=======================================
Hits 1089 1089
Misses 377 377 |
tiborsimko
reviewed
Aug 8, 2024
Dockerfile
Outdated
| @@ -85,6 +85,7 @@ EXPOSE 5000 | |||
| # Run server | |||
| # exec is used to make sure signals are propagated to uwsgi, | |||
| # while also allowing shell expansion | |||
| SHELL ["/bin/bash", "-c"] | |||
There was a problem hiding this comment.
Could you move the SHELL directive into its own paragraph, perhaps somewhere at the top of the Dockerfile? E.g. in the Ntupling Service backend we are using:
# Configure shell options
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
Fix the `JSONArgsRecommended` warning by explicitly setting the shell to be used when running the Dockerfile's `CMD` command. Note that it is not possible to switch to the exec form of `CMD`, as it lacks environment variable expansion. Closes reanahub#596
mdonadoni
force-pushed
the
fix-lint-error-dockerfile
branch
from
88f9b39
to
fb9923c
Compare
tiborsimko
approved these changes
Aug 9, 2024
jlemesh
pushed a commit
to jlemesh/reana-workflow-controller
that referenced
this pull request
Aug 16, 2024
Fix the `JSONArgsRecommended` warning by explicitly setting the shell to be used when running the Dockerfile's `CMD` command. Note that it is not possible to switch to the exec form of `CMD`, as it lacks environment variable expansion. Closes reanahub#596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
JSONArgsRecommendedwarning by explicitly setting the shell tobe used when running the Dockerfile's
CMDcommand. Note that it is notpossible to switch to the exec form of
CMD, as it lacks environmentvariable expansion.
Closes #596