Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docker): fix JSONArgsRecommended warning #596

Closed
tiborsimko opened this issue Aug 7, 2024 · 0 comments · Fixed by #598 · May be fixed by #578
Closed

build(docker): fix JSONArgsRecommended warning #596

tiborsimko opened this issue Aug 7, 2024 · 0 comments · Fixed by #598 · May be fixed by #578
Assignees
@mdonadoni

Comments

@tiborsimko
Copy link
Member

Current behaviour

$ reana-dev docker-build -c r-w-controller
...
 => WARN: JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 89)

See https://docs.docker.com/go/dockerfile/rule/json-args-recommended/

Expected behaviour

No warnings should be printed during container image building of REANA components.
@mdonadoni mdonadoni self-assigned this Aug 8, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue Aug 8, 2024
@mdonadoni
fix(docker): explicitly specify shell (reanahub#598)
d90eece 
Fix the `JSONArgsRecommended` warning by explicitly setting the shell to
be used when running the Dockerfile's `CMD` command. Note that it is not
possible to switch to the exec form of `CMD`, as it lacks environment
variable expansion.

Closes reanahub#596
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue Aug 8, 2024
@mdonadoni
fix(docker): explicitly specify shell (reanahub#598)
88f9b39 
Fix the `JSONArgsRecommended` warning by explicitly setting the shell to
be used when running the Dockerfile's `CMD` command. Note that it is not
possible to switch to the exec form of `CMD`, as it lacks environment
variable expansion.

Closes reanahub#596
@mdonadoni mdonadoni mentioned this issue Aug 8, 2024
Merged
@mdonadoni mdonadoni added this to 0.95.0 Aug 8, 2024
@mdonadoni mdonadoni moved this to In review in 0.95.0 Aug 8, 2024
@github-actions github-actions bot mentioned this issue Aug 9, 2024
Open
jlemesh pushed a commit to jlemesh/reana-workflow-controller that referenced this issue Aug 16, 2024
@mdonadoni @jlemesh
fix(docker): explicitly specify shell (reanahub#598)
6a29c51 
Fix the `JSONArgsRecommended` warning by explicitly setting the shell to
be used when running the Dockerfile's `CMD` command. Note that it is not
possible to switch to the exec form of `CMD`, as it lacks environment
variable expansion.

Closes reanahub#596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdonadoni mdonadoni

Labels
None yet
Projects
0.95.0
Status: Done
Milestone
No milestone
2 participants
@tiborsimko @mdonadoni