Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive-sessions: implement configurable allowlist #569

Closed
4 tasks
mdonadoni opened this issue Feb 12, 2024 · 0 comments · Fixed by reanahub/reana-ui#405, reanahub/reana#795, #582, reanahub/reana-server#688 or reanahub/reana#802

Comments

@mdonadoni
Copy link
Member

mdonadoni commented Feb 12, 2024

Let's add a configurable allowlist of docker images among which users can choose when starting a new interactive session.

Things to do:

  • Decide how to let the admins customise this allowlist (most probably helm value?)
  • Implement the actual allowlist checks in reana-workflow-controller
  • Decide whether to let users choose the docker image also from the UI. In this case, the list needs to be exposed also in web interface.
  • Bonus point: instead of a simple allowlist, consider making customisable also other details about the docker images (e.g. web port used, env variables needfed, etc.). This is a much bigger task, though.

Note that not all docker images are compatible with the way we currently deploy jupyter notebooks (e.g. they might expose a different port, etc.)

@mdonadoni mdonadoni self-assigned this Apr 11, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue Apr 17, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue May 8, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue May 27, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue May 27, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue Aug 8, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue Aug 8, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this issue Aug 8, 2024
@mdonadoni mdonadoni added this to 0.95.0 Aug 8, 2024
@mdonadoni mdonadoni moved this to Done in 0.95.0 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment