feat(sessions): add recommended images to info endpoint #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
May 27, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
0d2fcee
to
84f3591
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Jun 18, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
84f3591
to
a1db601
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Aug 8, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
a1db601
to
36e254e
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Aug 9, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
36e254e
to
36adb76
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #688 +/- ##
==========================================
+ Coverage 60.06% 60.13% +0.06%
==========================================
Files 32 32
Lines 3556 3562 +6
==========================================
+ Hits 2136 2142 +6
Misses 1420 1420
|
Alputer
changed the title
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 1, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
36adb76
to
c485bac
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 1, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
c485bac
to
85c75c2
Compare
Alputer
changed the title
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 1, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
85c75c2
to
e785aee
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 1, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
e785aee
to
035c99d
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 11, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
035c99d
to
5238b4d
Compare
tiborsimko
reviewed
Nov 12, 2024
docs/openapi.json
Outdated
| @@ -465,6 +465,13 @@ | |||
| "title": "Default workspace", | |||
| "value": "/usr/share" | |||
| }, | |||
| "interactive_session_recommended_jupyter_images": { | |||
| "title": "Recommended jupyter images for interactive sessions", | |||
There was a problem hiding this comment.
s/jupyter/Jupyter in documentation strings
| @@ -428,6 +428,11 @@ def _get_rate_limit(env_variable: str, default: str) -> str: | |||
| ) | |||
| """Maximum allowed period (in days) for interactive session inactivity before automatic closure.""" | |||
|
|
|||
| REANA_INTERACTIVE_SESSIONS_ENVIRONMENTS = json.loads( | |||
There was a problem hiding this comment.
Can we also expose to the users in the info output whether the server allows to specify custom Jupyter images by users? See the interactive_sessions.environments.jupyter.allow_custom Helm value.
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 12, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
5238b4d
to
98a20ec
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 12, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
2 times, most recently
from
112aee4
to
228b0da
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 12, 2024
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 12, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
228b0da
to
36bda63
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 12, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
36bda63
to
0a4c4bd
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 12, 2024
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
0a4c4bd
to
0551091
Compare
tiborsimko
reviewed
Nov 12, 2024
docs/openapi.json
Outdated
| ] | ||
| }, | ||
| "interactive_sessions_custom_image_allowed": { | ||
| "title": "Whether users can set custom interactive session images or not", |
There was a problem hiding this comment.
Phrasing: Whether users are allowed to spawn custom interactive session images
reana_server/rest/info.py
Outdated
| value=REANA_INTERACTIVE_SESSIONS_ENVIRONMENTS_CUSTOM_ALLOWED, | ||
| ), | ||
| interactive_session_recommended_jupyter_images=dict( | ||
| title="Recommended jupyter images for interactive sessions", |
There was a problem hiding this comment.
Cosmetics: Jupyter (in uppercase)
Alputer
force-pushed
the
jupyter-allowlist-info
branch
from
0551091
to
908aca2
Compare
tiborsimko
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-workflow-controller#569