fix(gitlab): handle pagination of GitLab webhooks (#684) #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 60.06% 60.13% +0.06%
==========================================
Files 32 32
Lines 3308 3316 +8
==========================================
+ Hits 1987 1994 +7
- Misses 1321 1322 +1
|
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Apr 17, 2024
mdonadoni
force-pushed
the
pagination-webhooks
branch
from
d6adb77
to
f11c539
Compare
tiborsimko
approved these changes
May 3, 2024
reana_server/utils.py
Outdated
| @@ -511,27 +524,22 @@ def _get_gitlab_hook_id(project_id, gitlab_token): | |||
| """ | |||
| gitlab_hooks_url = ( | |||
| REANA_GITLAB_URL | |||
| + "/api/v4/projects/{0}/hooks?access_token={1}".format(project_id, gitlab_token) | |||
| + "/api/v4/projects/{0}/hooks?per_page=100&access_token={1}".format( | |||
There was a problem hiding this comment.
Perhaps we could introduce a new configuration variable in config.py with REANA_GITLAB_PER_PAGE = 100 so that the value wouldn't be hard-coded?
There was a problem hiding this comment.
I have introduced REANA_GITLAB_MAX_PER_PAGE
mdonadoni
force-pushed
the
pagination-webhooks
branch
from
f11c539
to
3f716f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #681
Closes #682