feat(gitlab): add filtering and pagination (#681) #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Mar 19, 2024
mdonadoni
force-pushed
the
filter-paginate-gitlab
branch
from
c43f9a8
to
14bc890
Compare
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Mar 19, 2024
mdonadoni
force-pushed
the
filter-paginate-gitlab
branch
from
14bc890
to
c5f79ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 59.46% 60.06% +0.60%
==========================================
Files 32 32
Lines 3298 3308 +10
==========================================
+ Hits 1961 1987 +26
+ Misses 1337 1321 -16
|
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Mar 20, 2024
BREAKING CHANGE: The response of `gitlab_projects` API endpoint has been modified to also include the pagination details. Closes reanahub#518
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Mar 20, 2024
BREAKING CHANGE: The response of `gitlab_projects` API endpoint has been modified to also include the pagination details. Closes reanahub#518
mdonadoni
force-pushed
the
filter-paginate-gitlab
branch
from
b88f105
to
deae9fa
Compare
mdonadoni
changed the title
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Mar 25, 2024
BREAKING CHANGE: The response of `gitlab_projects` API endpoint has been modified to also include the pagination details. Closes reanahub#518
mdonadoni
force-pushed
the
filter-paginate-gitlab
branch
from
deae9fa
to
eac3cbf
Compare
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Mar 25, 2024
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Mar 25, 2024
BREAKING CHANGE: The response of `gitlab_projects` API endpoint has been modified to also include the pagination details. Closes reanahub#518
mdonadoni
force-pushed
the
filter-paginate-gitlab
branch
from
eac3cbf
to
6e413bb
Compare
tiborsimko
approved these changes
Apr 15, 2024
reana_server/utils.py
Outdated
| @@ -509,23 +509,30 @@ def _get_gitlab_hook_id(project_id, gitlab_token): | |||
| :param project_id: Project id on GitLab. | |||
| :param gitlab_token: GitLab token. | |||
| """ | |||
| reana_hook_id = None | |||
| # FIXME: handle pagination of results | |||
There was a problem hiding this comment.
This is fixed by #684 , but I have removed it anyway given that it will be fixed soon
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Apr 17, 2024
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Apr 17, 2024
BREAKING CHANGE: The REST API endpoint `gitlab_projects` now includes pagination details. Closes reanahub#518
mdonadoni
force-pushed
the
filter-paginate-gitlab
branch
from
6e413bb
to
fb19584
Compare
BREAKING CHANGE: The REST API endpoint `gitlab_projects` now includes pagination details. Closes reanahub#518
mdonadoni
force-pushed
the
filter-paginate-gitlab
branch
from
fb19584
to
4d23c62
Compare
|
Updated the commit title, and also the BREAKING CHANGE notice to read as follows: BREAKING CHANGE: The REST API endpoint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(gitlab): add search query parameter to filter projects (feat(gitlab): add filtering and pagination (#681) #681)
feat(gitlab): add support for paginated project list (feat(gitlab): add filtering and pagination (#681) #681)
BREAKING CHANGE: The REST API endpoint
gitlab_projectsnow includespagination details.
Closes #518