Upgrade api client to networking v1 API #299
Conversation
VMois
changed the title
VMois
force-pushed
the
k8s_networking_api_upgrade
branch
from
266e241
to
9f22ad6
Compare
VMois
force-pushed
the
k8s_networking_api_upgrade
branch
from
9f22ad6
to
8f2a695
Compare
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 36.60% 36.60%
=======================================
Files 20 20
Lines 959 959
=======================================
Hits 351 351
Misses 608 608
|
VMois
force-pushed
the
k8s_networking_api_upgrade
branch
2 times, most recently
from
f50c3b9
to
862fd69
Compare
VMois
changed the title
VMois
force-pushed
the
k8s_networking_api_upgrade
branch
from
862fd69
to
0435519
Compare
reana_commons/k8s/api_client.py
Outdated
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| # FIXME: monkeypatch to avoid `Invalid value for `names`, must not be `None`` | |||
| # error when calling `current_k8s_corev1_api_client.list_node()`. | |||
| # After new Kubernetes release this should not be needed. | |||
| # After new Kubernetes release (1.22+) this should not be needed. | |||
There was a problem hiding this comment.
As for now, we still support 1.16+ clusters even if 1.22+ is possible so I kept this comment.
There was a problem hiding this comment.
reana's repository says 1.19+ only, so I guess we could remove this. (Or better change reana's lower bound to 1.16+ if that still works well.)
There was a problem hiding this comment.
According to kubernetes-client/python#895 the issue is still present on the 1.19 cluster. But, I have checked v22 of the k8s python client and it looks like they fixed the problem. Our mock corresponds to exactly the same code as in the library (details)
There was a problem hiding this comment.
v21 still needs mock, so I set version k8s python client version to be 22.x.
VMois
force-pushed
the
k8s_networking_api_upgrade
branch
2 times, most recently
from
ec6f7de
to
bf74347
Compare
reana_commons/k8s/api_client.py
Outdated
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| # FIXME: monkeypatch to avoid `Invalid value for `names`, must not be `None`` | |||
| # error when calling `current_k8s_corev1_api_client.list_node()`. | |||
| # After new Kubernetes release this should not be needed. | |||
| # After new Kubernetes release (1.22+) this should not be needed. | |||
There was a problem hiding this comment.
reana's repository says 1.19+ only, so I guess we could remove this. (Or better change reana's lower bound to 1.16+ if that still works well.)
| elif api == "networking.k8s.io/v1beta1": | ||
| api_client = client.NetworkingV1beta1Api() | ||
| elif api == "networking.k8s.io/v1": | ||
| api_client = client.NetworkingV1Api() |
There was a problem hiding this comment.
Please write a line in CHANGES.rst about this. We shall target 0.9.0a1 release.
There was a problem hiding this comment.
Not sure what is the procedure for version change. I put 0.9.0a1 in version.py
There was a problem hiding this comment.
Yes, that's good. You can also use reana-dev git-create-release-commit -c . to create an explicit release commit.
BTW this will need to amend cluster components's setup.py requirements to bump minimal requirements. So a set of PR to everything on the client and cluster side will be necessary. I can pair up on this in the afternoon.
There was a problem hiding this comment.
Yes, let's pair up. Not sure how to do release and reana-dev git-create-release-commit -c . command is not working (need to tag commit).
There was a problem hiding this comment.
Found a problem with the release-commit command. Add a release commit.
setup.py
Outdated
| @@ -31,7 +31,7 @@ def get_snakemake_pkg(extras=""): | |||
| extras_require = { | |||
| "docs": ["Sphinx>=1.4.4", "sphinx-rtd-theme>=0.1.9",], | |||
| "tests": tests_require, | |||
| "kubernetes": ["kubernetes>=11.0.0,<12.0.0",], | |||
| "kubernetes": ["kubernetes>=21.0.0,<22.0.0",], | |||
There was a problem hiding this comment.
I see the kubernetes library now has version 22.6 released on PyPI. Is it interesting to release upper boundary constraint?
There was a problem hiding this comment.
We can. Should I release it completely or just increase the upper boundary to 23.0.0? I would prefer to put an upper boundary to <23.0.0.
There was a problem hiding this comment.
I put version >=22,<23, for now, because it fixes the mock issue. Should we remove the upper boundary?
There was a problem hiding this comment.
Yes, please keep the upper boundary; It'll be safer.
VMois
force-pushed
the
k8s_networking_api_upgrade
branch
2 times, most recently
from
0dbbccd
to
760d6e7
Compare
- set Kubernetes Python client version to 22.x; - remove mock on V1ContainerImage as it was fixed starting Kubernetes Python client version 22+; closes reanahub/reana#482
VMois
force-pushed
the
k8s_networking_api_upgrade
branch
from
760d6e7
to
04a2d53
Compare
tiborsimko
force-pushed
the
k8s_networking_api_upgrade
branch
from
3f43cda
to
50235e4
Compare
| @@ -19,7 +19,7 @@ | |||
| history = open("CHANGES.rst").read() | |||
|
|
|||
| tests_require = [ | |||
| "pytest-reana>=0.8.1,<0.9.0", | |||
| "pytest-reana>=0.9.0a1,<0.10.0", | |||
There was a problem hiding this comment.
Note: depends on reanahub/pytest-reana#95
tiborsimko
force-pushed
the
k8s_networking_api_upgrade
branch
from
50235e4
to
1de5763
Compare
tiborsimko
force-pushed
the
k8s_networking_api_upgrade
branch
4 times, most recently
from
3f547dc
to
2b7fbb5
Compare
tiborsimko
force-pushed
the
k8s_networking_api_upgrade
branch
from
2b7fbb5
to
5734e68
Compare
closes reanahub/reana#482