list_node: v1_container_image: ValueError: Invalid value for `names`, must not be `None` #895

sebastian-philipp · 2019-07-25T12:17:44Z

Hey all,

I'm getting this when calling list_node():

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/kubernetes/client/apis/core_v1_api.py", line 13437, in list_node
    (data) = self.list_node_with_http_info(**kwargs)  # `kwargs` is empty.
  File "/usr/lib/python2.7/site-packages/kubernetes/client/apis/core_v1_api.py", line 13534, in list_node_with_http_info
    collection_formats=collection_formats)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 321, in call_api
    _return_http_data_only, collection_formats, _preload_content, _request_timeout)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 163, in __call_api
    return_data = self.deserialize(response_data, response_type)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 236, in deserialize
    return self.__deserialize(data, response_type)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 276, in __deserialize
    return self.__deserialize_model(data, klass)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 620, in __deserialize_model
    kwargs[attr] = self.__deserialize(value, attr_type)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 254, in __deserialize
    for sub_data in data]
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 276, in __deserialize
    return self.__deserialize_model(data, klass)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 620, in __deserialize_model
    kwargs[attr] = self.__deserialize(value, attr_type)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 276, in __deserialize
    return self.__deserialize_model(data, klass)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 620, in __deserialize_model
    kwargs[attr] = self.__deserialize(value, attr_type)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 254, in __deserialize
    for sub_data in data]
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 276, in __deserialize
    return self.__deserialize_model(data, klass)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py", line 622, in __deserialize_model
    instance = klass(**kwargs)
  File "/usr/lib/python2.7/site-packages/kubernetes/client/models/v1_container_image.py", line 52, in __init__
    self.names = names
  File "/usr/lib/python2.7/site-packages/kubernetes/client/models/v1_container_image.py", line 77, in names
    raise ValueError("Invalid value for `names`, must not be `None`")
ValueError: Invalid value for `names`, must not be `None`

Installed versions in the client (CentOS 7):

[root@kubic-2 /]# python
Python 2.7.5 (default, Jun 20 2019, 20:27:34) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-36)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> urllib3.__version__
'1.10.2'
>>> kubernetes.__version__
'8.0.1'
>>> yaml.__version__
'3.10'
>>> requests.__version__
'2.6.0'

kubernetes:

Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.4", GitCommit:"a87e9a978f65a8303aa9467537aa59c18122cbf9", GitTreeState:"clean", BuildDate:"2019-07-08T08:43:10Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

Found in ceph/ceph#29131

Is there any chance of getting list_node to work?

The text was updated successfully, but these errors were encountered:

sebastian-philipp · 2019-07-25T12:33:57Z

My workaround is a monkey-patch:

    from kubernetes.client.models.v1_container_image import V1ContainerImage
    def names(self, names):
        self._names = names
    V1ContainerImage.names = V1ContainerImage.names.setter(names)

roycaihw · 2019-07-30T17:40:57Z

/assign

roycaihw · 2019-07-30T20:13:44Z

names is a required field in containerImage by k8s Go type definition and by the generated openapi spec. Therefore the generated python client expects the field to not be None when deserializes the containerImage response from apiserver.

The problem is either in k8s or in the image being used, where kubelet could report null image names if no repo tag or digest exist for the image. Ref kubernetes/kubernetes#79018

Please either file an issue in k8s to follow up on kubernetes/kubernetes#79018, or provide repo tag / digest for the image

/close

k8s-ci-robot · 2019-07-30T20:13:46Z

@roycaihw: Closing this issue.

In response to this:

names is a required field in containerImage by k8s Go type definition and by the generated openapi spec. Therefore the generated python client expects the field to not be None when deserializes the containerImage response from apiserver.

The problem is either in k8s or in the image being used, where kubelet could report null image names if no repo tag or digest exist for the image. Ref kubernetes/kubernetes#79018

Please either file an issue in k8s to follow up on kubernetes/kubernetes#79018, or provide repo tag / digest for the image

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sebastian-philipp · 2019-07-31T08:32:49Z

After talking with @saschagrunert this seems to be related to how cri-o reports images to k8s. And there was a backport to a later patch release of 1.14.

If you specify the command like: f4i.py add-thingvisor -y thingVisor-helloWorld.yaml -z Earth you got an error. Traceback (most recent call last): File "/app/master-controller.py", line 977, in recv_addThingVisor deploy_zone, available_zones = get_deploy_zone(tv_zone) # receive {"zone":zone_tv, "gw":floatingIP} if zone exists, otherwise none File "/app/master-controller.py", line 559, in get_deploy_zone_on_kubernetes available_zones = k8s.list_available_node_zone() File "/app/kubernetes_functions.py", line 152, in list_available_node_zone api_response = api_instance.list_node() File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api/core_v1_api.py", line 13726, in list_node (data) = self.list_node_with_http_info(**kwargs) # noqa: E501 (snip) File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 295, in __deserialize File "/usr/local/lib/python3.6/site-packages/kubernetes/client/models/v1_container_image.py", line 75, in names raise ValueError("Invalid value for `names`, must not be `None`") # noqa: E501 ValueError: Invalid value for `names`, must not be `None` kubernetes-client/python#895 This commit adds a workaround for this error. Signed-off-by: Hajime Tazaki <[email protected]>

If you specify the command like: f4i.py add-thingvisor -y thingVisor-helloWorld.yaml -z Earth you got an error. Traceback (most recent call last): File "/app/master-controller.py", line 977, in recv_addThingVisor deploy_zone, available_zones = get_deploy_zone(tv_zone) # receive {"zone":zone_tv, "gw":floatingIP} if zone exists, otherwise none File "/app/master-controller.py", line 559, in get_deploy_zone_on_kubernetes available_zones = k8s.list_available_node_zone() File "/app/kubernetes_functions.py", line 152, in list_available_node_zone api_response = api_instance.list_node() File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api/core_v1_api.py", line 13726, in list_node (data) = self.list_node_with_http_info(**kwargs) # noqa: E501 (snip) File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 295, in __deserialize File "/usr/local/lib/python3.6/site-packages/kubernetes/client/models/v1_container_image.py", line 75, in names raise ValueError("Invalid value for `names`, must not be `None`") # noqa: E501 ValueError: Invalid value for `names`, must not be `None` - related information kubernetes-client/python#895 Because I'm using containerd as a CRI (Container Runtime Interface), it might trigger this issue. This commit adds a workaround for this error. Signed-off-by: Hajime Tazaki <[email protected]>

If you specify the command like: f4i.py add-thingvisor -y thingVisor-helloWorld.yaml -z Earth you got an error. Traceback (most recent call last): File "/app/master-controller.py", line 977, in recv_addThingVisor deploy_zone, available_zones = get_deploy_zone(tv_zone) # receive {"zone":zone_tv, "gw":floatingIP} if zone exists, otherwise none File "/app/master-controller.py", line 559, in get_deploy_zone_on_kubernetes available_zones = k8s.list_available_node_zone() File "/app/kubernetes_functions.py", line 152, in list_available_node_zone api_response = api_instance.list_node() File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api/core_v1_api.py", line 13726, in list_node (data) = self.list_node_with_http_info(**kwargs) # noqa: E501 (snip) File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 295, in __deserialize File "/usr/local/lib/python3.6/site-packages/kubernetes/client/models/v1_container_image.py", line 75, in names raise ValueError("Invalid value for `names`, must not be `None`") # noqa: E501 ValueError: Invalid value for `names`, must not be `None` kubernetes-client/python#895 This commit adds a workaround for this error. Signed-off-by: Hajime Tazaki <[email protected]>

* Avoids having dangling docker images on the Kubernetes nodes because the Kubernetes Python library fails to list nodes (required by REANA-Commons and REANA-Server scheduler to determine if more workflows can be submitted) because of a validation error of data coming from the Kubernetes API. More information [here](kubernetes-client/python#895 (comment)). * Tags the kindest/node image to latest because after installation it has `none` tag, which makes it count as a dangling image.

doubleyewdee · 2021-03-25T01:28:35Z

Just ran into an issue with an Azure Kubernetes Service (AKS) 1.19.5 cluster where the above 'monkey patch' worked for me. We are migrating from 1.18.x to 1.19.x and found that a service using this API was broken.

The issue reproduces trivially on both the release (12.0.1) and alpha (17.14.0a1) packages. Should this issue really be closed?

doubleyewdee · 2021-03-25T01:46:35Z

Ok, this is a still open ~~k8s~~containerd bug, so yeah the issue I guess can be closed although as more users shuffle to containerd-backed clusters they may be surprised. :)

RobertDiPaolo · 2021-04-12T16:20:21Z

We've just run into this issue, I'm surprised this is closed. I appreciate the spec says it's required but it seems quite tight to reject the entire server response on a null field! Whatever happened to the Robustness Principal, i.e. be liberal in what you accept. We'll try the monkey patch for now.

doronmak · 2021-04-26T11:47:50Z

just get the same issue

alphaWizard · 2021-04-27T05:33:27Z

I ran into the same issue as well.

olix0r · 2021-05-19T21:20:17Z

There's some more discussion related to this issue here kubernetes/kubernetes#100802

roycaihw · 2021-05-19T23:34:48Z

/reopen

Please see more details in kubernetes/kubernetes#100802 (comment)

Until an agreement for some API change in SIG Node is made, we need to patch this client to treat None as []

/help

The fix can be made directly to

python/kubernetes/client/models/v1_container_image.py

Lines 79 to 80 in 821618f

    
           if self.local_vars_configuration.client_side_validation and names is None:  # noqa: E501 
        
               raise ValueError("Invalid value for `names`, must not be `None`")  # noqa: E501

After the fix is merged, the commit should be added to apply-hotfixes.sh as a cherrypick command, so that we can carry this fix when we re-generate this client.

k8s-ci-robot · 2021-05-19T23:34:49Z

@roycaihw: Reopened this issue.

In response to this:

/reopen

Please see more details in kubernetes/kubernetes#100802 (comment)

Until an agreement for some API change in SIG Node is made, we need to patch this client to treat None as []

/help

The fix can be made directly to

python/kubernetes/client/models/v1_container_image.py

Lines 79 to 80 in 821618f

if self.local_vars_configuration.client_side_validation and names is None: # noqa: E501

raise ValueError("Invalid value for `names`, must not be `None`") # noqa: E501

After the fix is merged, the commit should be added to apply-hotfixes.sh as a cherrypick command, so that we can carry this fix when we re-generate this client.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2021-05-20T16:36:53Z

update: the names field will be optional in k8s 1.22: kubernetes/kubernetes#102159. Before then, we still need to patch this client as mentioned in #895 (comment). I will send a patch next week if no one picks this up before me :)

To remove once Kubernetes releases the new version fixing it reanahub#197 kubernetes-client/python#895 kubernetes/kubernetes#102159

k8s-triage-robot · 2021-08-18T16:53:36Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2021-09-17T17:27:39Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2021-10-17T17:51:43Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2021-10-17T17:51:44Z

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lixd · 2024-05-11T09:36:44Z

get the same issue,when node in k8s has some image's name are none,like this:

$ circtl images
IMAGE                                                                      TAG                                 IMAGE ID            SIZE
<none>                                                                     <none>                              b24daf1f40e32       1.88GB

and when i remove this image,it works.

crictl rmi b24daf1f40e32

sebastian-philipp changed the title ~~list_node: ValueError: Invalid value for names, must not be None~~ list_node: v1_container_image: ValueError: Invalid value for names, must not be None Jul 25, 2019

k8s-ci-robot assigned roycaihw Jul 30, 2019

k8s-ci-robot closed this as completed Jul 30, 2019

This was referenced Jul 31, 2019

mgr/rook: Add caching for the Dashboard ceph/ceph#29131

Merged

Maybe add python-client to the integration tests? cri-o/cri-o#2685

Closed

diegodelemos mentioned this issue Jun 30, 2020

tasks: fail to submit workflow start operation reanahub/reana-commons#197

Open

roycaihw mentioned this issue May 19, 2021

K8S openapi spec mark ContainerImage.name as required kubernetes/kubernetes#100802

Closed

k8s-ci-robot reopened this May 19, 2021

roycaihw added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 19, 2021

olix0r mentioned this issue May 19, 2021

Workaround deserialization errors in Node API Arnavion/k8s-openapi#97

Closed

roycaihw mentioned this issue May 20, 2021

Mark ContainerImage.names as optional kubernetes/kubernetes#102159

Merged

mvidalgarcia added a commit to mvidalgarcia/reana-commons that referenced this issue Jun 9, 2021

k8s: add monkeypatch to solve list_node() error

4be4c92

To remove once Kubernetes releases the new version fixing it reanahub#197 kubernetes-client/python#895 kubernetes/kubernetes#102159

mvidalgarcia added a commit to mvidalgarcia/reana-commons that referenced this issue Jun 9, 2021

k8s: add monkeypatch to solve list_node() error

5cb55aa

To remove once Kubernetes releases the new version fixing it reanahub#197 kubernetes-client/python#895 kubernetes/kubernetes#102159

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 17, 2021

k8s-ci-robot closed this as completed Oct 17, 2021

mvidalgarcia mentioned this issue Oct 18, 2021

helm: upgrade to networking.k8s.io/v1 ingress reanahub/reana#482

Closed

VMois mentioned this issue Feb 22, 2022

Upgrade api client to networking v1 API reanahub/reana-commons#299

Merged

pbastia mentioned this issue Apr 25, 2022

Bug: nginx reload dag fails when crunchy postgres operator is installed in that namespace bcgov/cas-airflow#132

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

list_node: v1_container_image: ValueError: Invalid value for `names`, must not be `None` #895

list_node: v1_container_image: ValueError: Invalid value for `names`, must not be `None` #895

sebastian-philipp commented Jul 25, 2019 •

edited

Loading

sebastian-philipp commented Jul 25, 2019

roycaihw commented Jul 30, 2019

roycaihw commented Jul 30, 2019

k8s-ci-robot commented Jul 30, 2019

sebastian-philipp commented Jul 31, 2019

doubleyewdee commented Mar 25, 2021

doubleyewdee commented Mar 25, 2021 •

edited

Loading

RobertDiPaolo commented Apr 12, 2021

doronmak commented Apr 26, 2021

alphaWizard commented Apr 27, 2021

olix0r commented May 19, 2021

roycaihw commented May 19, 2021

k8s-ci-robot commented May 19, 2021

roycaihw commented May 20, 2021

k8s-triage-robot commented Aug 18, 2021

k8s-triage-robot commented Sep 17, 2021

k8s-triage-robot commented Oct 17, 2021

k8s-ci-robot commented Oct 17, 2021

lixd commented May 11, 2024

list_node: v1_container_image: ValueError: Invalid value for names, must not be None #895

list_node: v1_container_image: ValueError: Invalid value for names, must not be None #895

Comments

sebastian-philipp commented Jul 25, 2019 • edited Loading

sebastian-philipp commented Jul 25, 2019

roycaihw commented Jul 30, 2019

roycaihw commented Jul 30, 2019

k8s-ci-robot commented Jul 30, 2019

sebastian-philipp commented Jul 31, 2019

doubleyewdee commented Mar 25, 2021

doubleyewdee commented Mar 25, 2021 • edited Loading

RobertDiPaolo commented Apr 12, 2021

doronmak commented Apr 26, 2021

alphaWizard commented Apr 27, 2021

olix0r commented May 19, 2021

roycaihw commented May 19, 2021

k8s-ci-robot commented May 19, 2021

roycaihw commented May 20, 2021

k8s-triage-robot commented Aug 18, 2021

k8s-triage-robot commented Sep 17, 2021

k8s-triage-robot commented Oct 17, 2021

k8s-ci-robot commented Oct 17, 2021

lixd commented May 11, 2024

list_node: v1_container_image: ValueError: Invalid value for `names`, must not be `None` #895

list_node: v1_container_image: ValueError: Invalid value for `names`, must not be `None` #895

sebastian-philipp commented Jul 25, 2019 •

edited

Loading

doubleyewdee commented Mar 25, 2021 •

edited

Loading