Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add --follow flag to logs command (#729) #731

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Sep 27, 2024

Closes #730

Old code is moved to retrieve_workflow_logs function, log following implemented in follow_workflow_logs.

Added test for the command (both retrieval and following).

jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 27, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 10, 2024
reana_client/cli/utils.py Show resolved Hide resolved
reana_client/cli/workflow.py Outdated Show resolved Hide resolved
reana_client/cli/workflow.py Outdated Show resolved Hide resolved
reana_client/cli/workflow.py Show resolved Hide resolved
reana_client/cli/utils.py Outdated Show resolved Hide resolved
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 14, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 14, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 14, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 15, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 15, 2024
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 17, 2024
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works nicely 👍

I have fixed the docstring typo and amended commitlint scope.

@tiborsimko tiborsimko merged commit dda80d1 into reanahub:master Oct 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: display live logs
2 participants