Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add --follow flag to logs command (#161) #161

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Oct 1, 2024

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.18%. Comparing base (955bda8) to head (a8e3672).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   85.44%   84.18%   -1.26%     
==========================================
  Files          41       41              
  Lines        2919     3542     +623     
==========================================
+ Hits         2494     2982     +488     
- Misses        333      471     +138     
+ Partials       92       89       -3     
Files with missing lines Coverage Δ
cmd/logs.go 95.14% <100.00%> (+5.40%) ⬆️
pkg/config/config.go 100.00% <100.00%> (ø)

... and 38 files with indirect coverage changes

jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 1, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from 396cda1 to e322c31 Compare October 1, 2024 13:30
jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 1, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from e322c31 to a8e1dd2 Compare October 1, 2024 14:43
jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 1, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from a8e1dd2 to 88cfd8a Compare October 1, 2024 14:54
jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 1, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from 88cfd8a to 5a004a6 Compare October 1, 2024 15:10
cmd/logs.go Outdated Show resolved Hide resolved
jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 15, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from 5a004a6 to a6993dd Compare October 15, 2024 11:05
jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 15, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from a6993dd to 031eb3f Compare October 15, 2024 11:21
jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 17, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from 031eb3f to 6a50ea4 Compare October 17, 2024 13:09
jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 17, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from 6a50ea4 to f6d4e00 Compare October 17, 2024 13:13
jlemesh added a commit to jlemesh/reana-client-go that referenced this pull request Oct 17, 2024
@jlemesh jlemesh force-pushed the feature_add_logs_follow_option branch from f6d4e00 to f249c7f Compare October 17, 2024 13:15
tiborsimko pushed a commit to jlemesh/reana-client-go that referenced this pull request Oct 21, 2024
@tiborsimko tiborsimko force-pushed the feature_add_logs_follow_option branch from f249c7f to 565f929 Compare October 21, 2024 13:41
@tiborsimko tiborsimko force-pushed the feature_add_logs_follow_option branch from 565f929 to a8e3672 Compare October 21, 2024 13:43
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍

(BTW I have fixed the docs typo and changed the commitlint scope.)

@tiborsimko tiborsimko merged commit a8e3672 into reanahub:master Oct 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: display live logs
2 participants