-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add --follow flag to logs command (#161) #161
Merged
tiborsimko
merged 1 commit into
reanahub:master
from
jlemesh:feature_add_logs_follow_option
Oct 21, 2024
Merged
feat(cli): add --follow flag to logs command (#161) #161
tiborsimko
merged 1 commit into
reanahub:master
from
jlemesh:feature_add_logs_follow_option
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 85.44% 84.18% -1.26%
==========================================
Files 41 41
Lines 2919 3542 +623
==========================================
+ Hits 2494 2982 +488
- Misses 333 471 +138
+ Partials 92 89 -3
|
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 1, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 1, 2024 13:30
396cda1
to
e322c31
Compare
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 1, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 1, 2024 14:43
e322c31
to
a8e1dd2
Compare
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 1, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 1, 2024 14:54
a8e1dd2
to
88cfd8a
Compare
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 1, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 1, 2024 15:10
88cfd8a
to
5a004a6
Compare
tiborsimko
reviewed
Oct 14, 2024
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 15, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 15, 2024 11:05
5a004a6
to
a6993dd
Compare
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 15, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 15, 2024 11:21
a6993dd
to
031eb3f
Compare
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 17, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 17, 2024 13:09
031eb3f
to
6a50ea4
Compare
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 17, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 17, 2024 13:13
6a50ea4
to
f6d4e00
Compare
jlemesh
added a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 17, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_option
branch
from
October 17, 2024 13:15
f6d4e00
to
f249c7f
Compare
tiborsimko
pushed a commit
to jlemesh/reana-client-go
that referenced
this pull request
Oct 21, 2024
tiborsimko
force-pushed
the
feature_add_logs_follow_option
branch
from
October 21, 2024 13:41
f249c7f
to
565f929
Compare
tiborsimko
force-pushed
the
feature_add_logs_follow_option
branch
from
October 21, 2024 13:43
565f929
to
a8e3672
Compare
tiborsimko
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely 👍
(BTW I have fixed the docs typo and changed the commitlint scope.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-client#730
Similar to reanahub/reana-client#731 but in go.