-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add --follow flag to logs command (#729) #731
Merged
tiborsimko
merged 1 commit into
reanahub:master
from
jlemesh:feature_add_logs_follow_cmd
Oct 21, 2024
Merged
feat(cli): add --follow flag to logs command (#729) #731
tiborsimko
merged 1 commit into
reanahub:master
from
jlemesh:feature_add_logs_follow_cmd
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Sep 27, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
September 27, 2024 15:42
aaaf7e4
to
e1773a9
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Sep 30, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
September 30, 2024 08:42
e1773a9
to
3327a56
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Sep 30, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
September 30, 2024 08:44
3327a56
to
90a9109
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Sep 30, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
September 30, 2024 12:30
90a9109
to
08913d3
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Sep 30, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
September 30, 2024 12:33
08913d3
to
18e3052
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Sep 30, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
September 30, 2024 12:35
18e3052
to
1094750
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Oct 10, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
October 10, 2024 13:24
1094750
to
ab17590
Compare
tiborsimko
reviewed
Oct 14, 2024
tiborsimko
reviewed
Oct 14, 2024
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Oct 14, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
October 14, 2024 15:38
ab17590
to
7993bbf
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Oct 14, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
October 14, 2024 15:39
7993bbf
to
81d36fd
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Oct 14, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
October 14, 2024 15:44
81d36fd
to
bfff557
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Oct 15, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
October 15, 2024 08:47
bfff557
to
a9ef8dc
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Oct 15, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
October 15, 2024 08:51
a9ef8dc
to
68fcaae
Compare
jlemesh
added a commit
to jlemesh/reana-client
that referenced
this pull request
Oct 17, 2024
jlemesh
force-pushed
the
feature_add_logs_follow_cmd
branch
from
October 17, 2024 10:57
68fcaae
to
9ba012f
Compare
tiborsimko
force-pushed
the
feature_add_logs_follow_cmd
branch
from
October 21, 2024 13:58
9ba012f
to
dda80d1
Compare
tiborsimko
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works nicely 👍
I have fixed the docstring typo and amended commitlint scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #730
Old code is moved to
retrieve_workflow_logs
function, log following implemented infollow_workflow_logs
.Added test for the command (both retrieval and following).