Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CfdOF cfmesh fails meshing geometry. Geometry error on Cut ? #770

Open
linuxguy123 opened this issue Mar 22, 2023 · 3 comments
Open

CfdOF cfmesh fails meshing geometry. Geometry error on Cut ? #770

linuxguy123 opened this issue Mar 22, 2023 · 3 comments

Comments

@linuxguy123
Copy link

Steps to reproduce.

  1. Install CfdOF workbench
  2. Load attached example file - recalculate or not, makes no difference
  3. Doubleclick Cut_Mesh under CfdAnalysis object
  4. Write mesh
  5. Run mesh

The mesher will hang in RT, works fine in mainline FC. Stopping the mesh process in CfdOF will not kill the process on the computer. That will have to be done manually.

For some reason RT is exporting a slightly different geometry for the Cut Ojbect than the mainline version. Tested it with Validate Shape and Fix Shape on and off, using Recompute Object after each change.

naca2412_BH.zip

Bad Mesh Session.txt

Good Mesh Session.txt

Number of bad faces

@linuxguy123 linuxguy123 changed the title CfdOF cfmesh fails meshing geometry. Geometry error ? CfdOF cfmesh fails meshing geometry. Geometry error on Cut ? Mar 22, 2023
@linuxguy123
Copy link
Author

I confirmed there is an issue with how RT generates geometry compared to mainline FreeCAD.

The test case above runs properly in mainline FreeCAD. If the geometry is slightly changed (make windtunnel object wider) it also runs properly in RT.

@realthunder
Copy link
Owner

Which version of upstream FreeCAD you've tried? And which OpenFoam version you've installed? I tried on Linux with Fundation OpenFoam. Both mine and upstream FreeCAD got Meshing exited with error after click Run mesher.

@linuxguy123
Copy link
Author

linuxguy123 commented Mar 27, 2023

I'll leave this issue open and reply to it when I find it happening again. It has something to do with specific mesh parameters. In general CfdOF meshing works in RT, but there is an inconsistency in the geometry or how it is used somewhere.

realthunder pushed a commit that referenced this issue Dec 26, 2023
4.5.0 - 2023-10-07
Features
requirements-txt-fixer: also sort constraints.txt by default.
#857 PR by @lev-blit.
#830 issue by @PLPeeters.
debug-statements: add bpdb debugger.
#942 PR by @mwip.
#941 issue by @mwip.
Fixes
file-contents-sorter: fix sorting an empty file.
#944 PR by @RoelAdriaans.
#935 issue by @paduszyk.
double-quote-string-fixer: don't rewrite inside f-strings in 3.12+.
#973 PR by @asottile.
#971 issue by @XuehaiPan.
Migrating
now requires python >= 3.8.
#926 PR by @asottile.
#927 PR by @asottile.
4.4.0 - 2022-11-23
Features
forbid-submodules: new hook which outright bans submodules.
#815 PR by @asottile.
#707 issue by @ChiefGokhlayeh.
4.3.0 - 2022-06-07
Features
check-executables-have-shebangs: use git config core.fileMode to determine if it should query git.
#730 PR by @Kurt-von-Laven.
name-tests-test: add --pytest-test-first test convention.
#779 PR by @asottile.
Fixes
check-shebang-scripts-are-executable: update windows instructions.
#774 PR by @mdeweerd.
#770 issue by @mdeweerd.
check-toml: use stdlib tomllib when available.
#771 PR by @DanielNoord.
#755 issue by @sognetic.
check-added-large-files: don't run on non-file stages.
#778 PR by @asottile.
#777 issue by @skyj.
4.2.0 - 2022-04-06
Features
name-tests-test: updated display text.
#713 PR by @asottile.
check-docstring-first: make output more parsable.
#748 PR by @asottile.
check-merge-conflict: make output more parsable.
#748 PR by @asottile.
debug-statements: make output more parsable.
#748 PR by @asottile.
Fixes
check-merge-conflict: fix detection of ====== conflict marker on windows.
#748 PR by @asottile.
Updating
Drop python<3.7.
#719 PR by @asottile.
Changed default branch from master to main.
#744 PR by @asottile.
4.1.0 - 2021-12-22
Features
debug-statements: add pdbr debugger.
#614 PR by @cansarigol.
detect-private-key: add detection for additional key types.
#658 PR by @ljmf00.
check-executables-have-shebangs: improve messaging on windows.
#689 PR by @pujitm.
#686 issue by @jmerdich.
check-added-large-files: support --enforce-all with git-lfs.
#674 PR by @amartani.
#560 issue by @jeremy-coulon.
Fixes
check-case-conflict: improve performance.
#626 PR by @guykisel.
#625 issue by @guykisel.
forbid-new-submodules: fix false-negatives for pre-push.
#619 PR by @m-khvoinitsky.
#609 issue by @m-khvoinitsky.
check-merge-conflict: fix execution in git worktrees.
#662 PR by @errsyn.
#638 issue by @daschuer.
Misc.
Normalize case of hook names and descriptions.
#671 PR by @dennisroche.
#673 PR by @revolter.
4.0.1 - 2021-05-16
Fixes
check-shebang-scripts-are-executable fix entry point.
#602 issue by @Person-93.
#603 PR by @scop.
4.0.0 - 2021-05-14
Features
check-json: report duplicate keys.
#558 PR by @AdityaKhursale.
#554 issue by @adamchainz.
no-commit-to-branch: add main to default blocked branches.
#565 PR by @ndevenish.
check-case-conflict: check conflicts in directory names as well.
#575 PR by @slsyy.
#70 issue by @andyjack.
check-vcs-permalinks: forbid other branch names.
#582 PR by @jack1142.
#581 issue by @jack1142.
check-shebang-scripts-are-executable: new hook which ensures shebang'd scripts are executable.
#545 PR by @scop.
Fixes
check-executables-have-shebangs: Short circuit shebang lookup on windows.
#544 PR by @scop.
requirements-txt-fixer: Fix comments which have indentation
#549 PR by @greshilov.
#548 issue by @greshilov.
pretty-format-json: write to stdout using UTF-8 encoding.
#571 PR by @jack1142.
#570 issue by @jack1142.
Use more inclusive language.
#599 PR by @asottile.
Breaking changes
Remove deprecated hooks: flake8, pyflakes, autopep8-wrapper.
#597 PR by @asottile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants