Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): resource warnings about unclosed file #232

Merged
merged 2 commits into from
May 23, 2024
Merged

fix(tests): resource warnings about unclosed file #232

merged 2 commits into from
May 23, 2024

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented May 8, 2024

It suppresses 19 warnings, even if it's just noise.

Also removed an unused import and fixed an obvious comparison.

@BoboTiG BoboTiG requested a review from a team as a code owner May 8, 2024 15:38
@BoboTiG BoboTiG requested a review from stsewd May 8, 2024 15:38
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time and fix this 🎉

@humitos humitos merged commit bbc8127 into readthedocs:main May 23, 2024
8 checks passed
@BoboTiG BoboTiG deleted the fix-resource-warnings branch May 23, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants