fix(tests): resource warnings about unclosed file (#232)

Co-authored-by: Manuel Kaufmann <[email protected]>
readthedocs · May 23, 2024 · bbc8127 · bbc8127
1 parent 68fe9e6
commit bbc8127
Showing 1 changed file with 17 additions and 17 deletions.
diff --git a/tests/test_urls.py b/tests/test_urls.py
@@ -57,7 +57,7 @@ def test_default_settings(app, status, warning):
     app.build()
     path = app.outdir / '404.html'
     assert path.exists()
-    content = open(path).read()
+    content = path.read_text()
 
     if sphinx.version_info < (6, 0):
         cssclass = "shortcut "
@@ -97,7 +97,7 @@ def test_context_settings(app, status, warning):
     app.build()
     path = app.outdir / '404.html'
     assert path.exists()
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         '<h1>Boo!</h1>',
@@ -132,7 +132,7 @@ def test_urls_prefix_setting(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     if sphinx.version_info < (6, 0):
         cssclass = "shortcut "
@@ -170,7 +170,7 @@ def test_urls_prefix_setting_none(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     if sphinx.version_info < (6, 0):
         cssclass = "shortcut "
@@ -213,7 +213,7 @@ def test_template_setting(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         'Custom title',
@@ -237,7 +237,7 @@ def test_custom_404_rst_source(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         # custom 404.rst file content
@@ -279,7 +279,7 @@ def test_image_on_404_rst_source(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         # .. image::
@@ -313,7 +313,7 @@ def test_image_looks_like_absolute_url(app, status, warning):
 
     path = app.outdir / '404.html'
     assert path.exists()
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         '<img alt="PATH looking as an URL" src="/en/latest/_images/https.png" />',
@@ -327,8 +327,8 @@ def test_image_looks_like_absolute_url(app, status, warning):
 def test_image_absolute_url(app, status, warning):
     app.build()
     path = app.outdir / '404.html'
-    assert path.exists() is True
-    content = open(path).read()
+    assert path.exists()
+    content = path.read_text()
 
     chunks = [
         '<img alt="Read the Docs Logo" src="https://read-the-docs-guidelines.readthedocs-hosted.com/_images/logo-dark.png" />',
@@ -347,7 +347,7 @@ def test_urls_for_dirhtml_builder(app, status, warning):
     path = app.outdir / '404' / 'index.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         # sidebar URLs
@@ -370,7 +370,7 @@ def test_sphinx_resource_urls(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         # Sphinx's resources URLs
@@ -398,7 +398,7 @@ def test_toctree_urls_notfound_default(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         # sidebar URLs
@@ -423,7 +423,7 @@ def test_toctree_links(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         '<h3>Navigation</h3>',
@@ -445,7 +445,7 @@ def test_toctree_links_custom_settings(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         '<h3>Navigation</h3>',
@@ -470,7 +470,7 @@ def test_resources_from_extension(app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
     chunks = [
         '<link rel="stylesheet" type="text/css" href="/en/latest/_static/css_added_by_extension.css" />',
         '<link rel="stylesheet" type="text/css" href="/en/latest/_static/css_added_by_extension.css" />',
@@ -492,7 +492,7 @@ def test_special_readthedocs_urls(environ, app, status, warning):
     path = app.outdir / '404.html'
     assert path.exists()
 
-    content = open(path).read()
+    content = path.read_text()
 
     chunks = [
         # Link included manually