Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI updates to Connected Accounts #9891

Merged
merged 1 commit into from
Jan 12, 2023
Merged

UI updates to Connected Accounts #9891

merged 1 commit into from
Jan 12, 2023

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jan 12, 2023 •
edited
Loading

Related to additions in #9834

Also related: The terminology of "Git provider" to be discussed in #9840

Example:

image

@benjaoming
Add reference to our documentation from Connected Accounts and add a …
3a053d7 
…text about how to fully disconnect an account.
@benjaoming benjaoming added the Improvement Minor improvement to code label Jan 12, 2023
@benjaoming benjaoming requested a review from a team as a code owner January 12, 2023 16:55
@benjaoming benjaoming requested a review from agjohnson January 12, 2023 16:55
@benjaoming benjaoming changed the title Updates to Connected Accounts UI updates to Connected Accounts Jan 12, 2023
ericholscher
ericholscher approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great change, but I do think we should be minimizing UI changes on the old dashboard and trying to push ahead on the new one. But these smallish fixes are good 👍

@benjaoming
Copy link
Contributor Author

definitely agree to minimalizing changes, but the additional help-text was pushing the "Connect to " buttons further down... so they looked very "secondary"... that made it nicer to move them to the top, after which the page needed an introduction text and thus: 🐰 🕳️

Gonna just read the comments about "Git provider" before merging...

@benjaoming benjaoming merged commit fb188c4 into readthedocs:main Jan 12, 2023
@benjaoming benjaoming deleted the add-notice-on-disconnecting-service branch January 12, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/frontend

Assignees

@benjaoming benjaoming

Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaoming @ericholscher