Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Relabel and move explanation and how-tos around OAuth (Diátaxis) #9834

Merged
merged 20 commits into from
Jan 13, 2023
Merged

Docs: Relabel and move explanation and how-tos around OAuth (Diátaxis) #9834

merged 20 commits into from
Jan 13, 2023

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Dec 21, 2022 •
edited
Loading

Refs: #9746

📚 Documentation previews 📚

@benjaoming benjaoming mentioned this pull request Dec 21, 2022
Closed
38 tasks
@benjaoming benjaoming changed the base branch from main to diataxis/main December 21, 2022 15:39
@benjaoming benjaoming added Improvement Minor improvement to code Needed: documentation Documentation is required labels Dec 21, 2022
@benjaoming benjaoming changed the title Docs: Relabel and move explanation and how-tos around OAuth Docs: Relabel and move explanation and how-tos around OAuth (Diátaxis) Dec 21, 2022
@benjaoming benjaoming marked this pull request as ready for review January 3, 2023 18:14
@benjaoming benjaoming requested a review from a team as a code owner January 3, 2023 18:14
ericholscher
ericholscher reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start on a refactor, but definitely suffers from the "how to not being useful" problem.

docs/user/connected-accounts.rst Outdated Show resolved Hide resolved
docs/user/connected-accounts.rst Outdated Show resolved Hide resolved
docs/user/connected-accounts.rst Outdated Show resolved Hide resolved
docs/user/connected-accounts.rst Outdated Show resolved Hide resolved
docs/user/guides/connecting-git-account.rst Outdated Show resolved Hide resolved
@benjaoming benjaoming mentioned this pull request Jan 12, 2023
Merged
@benjaoming benjaoming mentioned this pull request Jan 12, 2023
Merged
ericholscher
ericholscher approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking a lot closer to me. I think it's pretty ready to merge.

docs/user/guides/connecting-git-account.rst Outdated Show resolved Hide resolved
docs/user/guides/connecting-git-account.rst Outdated Show resolved Hide resolved
docs/user/guides/connecting-git-account.rst
you will be taken back to Read the Docs.
You will now see the account appear in the list of connected services.

.. figure:: /img/screenshot_connected_services.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love Donald Docs as a test user 😆

@benjaoming benjaoming merged commit 9b11d9c into readthedocs:diataxis/main Jan 13, 2023
@benjaoming benjaoming deleted the diataxis/relabel-connected-accounts branch January 13, 2023 11:15
@ericholscher ericholscher mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@ericholscher ericholscher ericholscher approved these changes

Assignees

@benjaoming benjaoming

Labels
Improvement Minor improvement to code Needed: documentation Documentation is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaoming @ericholscher @humitos