Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Split up Pull Request Builds into a how-to guide and reference (Diátaxis) #9679

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Oct 19, 2022

Refs #9746


📚 Documentation previews 📚

@benjaoming benjaoming added the Improvement Minor improvement to code label Oct 19, 2022
@benjaoming benjaoming requested a review from a team as a code owner October 19, 2022 16:00
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Requesting changes" here until we decide the next steps in the conversation we are having in #9676

Note for the future: we are renaming a file, so that we will require a redirect in place.

@benjaoming
Copy link
Contributor Author

Note for the future: we are renaming a file, so that we will require a redirect in place.

No files are renamed here, the old file stays in place and a new file is added.

We have in the overall plan for this project to not remove any files, so we don't have to become distracted with file names, folder names nor redirects.

@benjaoming benjaoming force-pushed the diataxis/split-pull-request-builds branch 2 times, most recently from 203044f to 345d9f5 Compare October 21, 2022 14:57
@benjaoming benjaoming requested a review from humitos October 21, 2022 14:58
@benjaoming benjaoming marked this pull request as draft November 9, 2022 22:23
@benjaoming benjaoming changed the base branch from main to diataxis/main November 24, 2022 14:32
@benjaoming benjaoming marked this pull request as ready for review December 9, 2022 17:57
@benjaoming benjaoming dismissed humitos’s stale review December 9, 2022 17:58

We have decided the next steps 👍

@benjaoming benjaoming force-pushed the diataxis/split-pull-request-builds branch from bfeaa49 to 797a7f4 Compare December 9, 2022 18:15
@benjaoming
Copy link
Contributor Author

This is ready and reviewed.

Site-note: Picked up a conversation about finding a repeatable pattern for "Only available on Sphinx" messages. But that can be introduced in another changeset.

Merging this one...

@benjaoming benjaoming merged commit 2f64539 into readthedocs:diataxis/main Dec 9, 2022
@benjaoming benjaoming deleted the diataxis/split-pull-request-builds branch December 9, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants