-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Split Custom Domains as Explanation and How-to Guide (Diátaxis) #9676
Docs: Split Custom Domains as Explanation and How-to Guide (Diátaxis) #9676
Conversation
33afde5
to
6b08a64
Compare
At first, I thought that a good text about custom domains would end up missing in the features reference - but it turns out, the subject is already covered here: https://docs.readthedocs.io/en/stable/hosting.html |
Takeaways from discussion about how the first easy Diátaxis refactors should take place and be reviewed focused on this PR, so here are the comments:
|
Another take-away: We don't want to clog up the reviewing process with too many PRs. So I'll keep an absolute maximum of 10 PRs and me and @humitos will evaluate - maybe by end of Thursday. |
From our meeting; We talked a bit about this page specifically -- this is a good example page because it does have more of the content that we'd like to have for each feature. So, I'll home discussion notes here. This might be a great feature to iron out some of our patterns on, given it is more complex. But some of this is applicable to all feature pages. We noted:
So, perhaps we still need to define our end goal around structure. This is something we can discuss, but as a starting point:
It's not clear if we're at the point that we're talking about splitting up into pages |
I think that we need a separate discussion dedicated to proposals for an over-all navigation structure / topic template. |
But I like where the idea is heading! |
Yeah, and there are probably two conversations there too: what navigation structure do we need for features immediately, and what navigation structure changes are there overall. We can probably discuss the two in isolation, if it helps to be explicit with our initial plan. However, I think what we described so far is that existing navigation structure shouldn't change much yet. Instead, we're talking about adding new pages, and mostly need to find homes for content that we're moving. Overall, there are conversations around where we move feature content for RTD for business, guide content that borders on explanation content or general feature content, etc. |
I think we're to the point where more semantic structure would help organization of all of these concepts. I think it's best to create new structure that has more semantic meaning for feature sub pages, like:
|
Co-authored-by: Anthony <[email protected]>
Co-authored-by: Anthony <[email protected]>
…readthedocs.org into diataxis/move-custom-domains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. It's definitely better than what it was before 💯
It follows some of the topics that we discuss in our meeting and it splits the content in the way we talked:
- "feature" page with an introduction to the topic
- "how to" document that explains how to use the feature itself
It does not split its content into an extra "troubleshooting" page --for now, it seems this content is still under the "how to". Do you think we should do this change on this PR as well? I'd like to have all the changes we would like to do on these pages in one PR, and use it as example for the others. I'm fine if we are skipping this chunk of work on all these PRs for now, tho.
After reading all the good feedback related to English in particular that @agjohnson provided to this PR, I'm not sure I'm the best fit to review all the other ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diagram is great, with some nitpicks about the exact language and process.
Co-authored-by: Eric Holscher <[email protected]>
…g into diataxis/move-custom-domains
I don't like the unfocused scope of "How To Manage Custom Domains" but I think we can live with this and instead put a note for Iteration 4. I think it'll be easier to make a decision about these "bundled" how-tos once we see them grouped together with all the other how-tos. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can get this merged once my small nitpicks are addressed and we removed the mermaid stuff 👍
This has already taken too much time, so I feel like more investment here is firmly in diminishing returns. We can come back and address any issues once users are using it.
Co-authored-by: Eric Holscher <[email protected]>
…readthedocs.org into diataxis/move-custom-domains
Our CSP works well 👍 The SVG generated on mermaid.live has fontawesome included from CDN and it doesn't work.
Will create a PNG. Also Mermaid docs say this:
And then mermaid.live embeds font-awesome 6 🙃 |
…readthedocs.org into diataxis/move-custom-domains
Mermaid Diagram finally works. A bit more cumbersome, but end result looks good to me. |
Intentional scope creep, refs: https://github.com/readthedocs/readthedocs.org/pull/9676/files#r1035201538
Fixes #8469
Refs #9746
📚 Documentation previews 📚
docs
): https://docs--9676.org.readthedocs.build/en/9676/dev
): https://dev--9676.org.readthedocs.build/en/9676/