Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme release 0.5.0rc1 for docs #7037

Merged
merged 8 commits into from
Jun 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@ formats: all
sphinx:
configuration: docs/conf.py
python:
install:
- requirements: requirements/local-docs-build.txt
install:
- requirements: requirements/pip.txt
- requirements: requirements/docs.txt
2 changes: 1 addition & 1 deletion docs/.rstcheck.cfg
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[rstcheck]
ignore_directives=automodule,http:get,tabs,tab,prompt,http:patch,http:post,http:put,http:delete
ignore_roles=djangosetting,setting,featureflags,buildpyversions
ignore_substitutions=org_brand,com_brand
ignore_substitutions=org_brand,com_brand,:smile:
# This error needs to be ignored for now
# See: https://github.com/myint/rstcheck/issues/19
ignore_messages=(Hyperlink target ".*" is not referenced)
2 changes: 1 addition & 1 deletion docs/development/docs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Follow the instructions just up to the point of activating the virtual environme

Next, install the documentation dependencies using ``pip`` (make sure you are inside of the virtual environment)::

pip install -r requirements/local-docs-build.txt
pip install -r requirements/docs.txt

This installs ``Sphinx``, amongst other things.

Expand Down
2 changes: 2 additions & 0 deletions requirements/deploy.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Requirements for our production systems

-r pip.txt
# http://initd.org/psycopg/docs/install.html#binary-install-from-pypi
psycopg2==2.8.3 --no-binary psycopg2
Expand Down
2 changes: 2 additions & 0 deletions requirements/docker.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Requirements for our local docker development

-r pip.txt
# http://initd.org/psycopg/docs/install.html#binary-install-from-pypi
psycopg2-binary==2.8.5
Expand Down
5 changes: 0 additions & 5 deletions requirements/docs-lint.txt

This file was deleted.

14 changes: 7 additions & 7 deletions requirements/local-docs-build.txt → requirements/docs.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-r pip.txt
# Packages required to build docs, independent of application dependencies

# Base packages
Sphinx==3.0.4

# doctuils==0.15 produces this error
# File "python3.6/site-packages/docutils/parsers/rst/states.py", line 882, in interpreted
Expand All @@ -10,18 +10,15 @@
# AttributeError: 'str' object has no attribute 'rawsource'
docutils==0.14 # pyup: ignore

sphinx_rtd_theme==0.4.3
sphinx_rtd_theme==0.5.0rc2
sphinx-tabs==1.1.13
# Required to avoid Transifex error with reserved slug
# https://github.com/sphinx-doc/sphinx-intl/pull/27
git+https://github.com/agjohnson/sphinx-intl.git@7b5c66bdb30f872b3b1286e371f569c8dcb66de5#egg=sphinx-intl
sphinx-intl==2.0.1

readthedocs-sphinx-search==0.1.0rc1

# Test out hoverxref
git+https://github.com/readthedocs/sphinx-hoverxref@master


Pygments==2.6.1

mkdocs==1.1
Expand All @@ -34,3 +31,6 @@ sphinx-prompt==1.0.0
sphinx-notfound-page==0.4
commonmark==0.9.1
recommonmark==0.6.0

# Linting
rstcheck==3.3.1
2 changes: 2 additions & 0 deletions requirements/lint.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Packages required for doing linting

-r pip.txt
# prospector 1.1.6.2 is not compatible with 2.1.0
astroid<=2.0.4 # pyup: ignore
Expand Down
1 change: 1 addition & 0 deletions requirements/pip.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Base packages

pip==20.1
appdirs==1.4.3
virtualenv==20.0.20
Expand Down
3 changes: 2 additions & 1 deletion requirements/testing.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Packages required for running tests

-r pip.txt
-r local-docs-build.txt

django-dynamic-fixture==3.1.0
pytest==5.4.2
Expand Down
4 changes: 3 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,12 @@ commands =
description = build readthedocs documentation
changedir = {toxinidir}/docs
commands =
pip install -r{toxinidir}/requirements/docs.txt # TODO: Remove this once our Sphinx versions don't conflict
sphinx-build -W --keep-going -b html -d {envtmpdir}/doctrees . {envtmpdir}/html

[testenv:docs-linkcheck]
description = Check for broken links in the docs
deps = -r{toxinidir}/requirements/docs.txt
changedir = {toxinidir}/docs
commands =
sphinx-build -W --keep-going -q -b linkcheck -d {envtmpdir}/doctrees . {envtmpdir}/linkcheck
Expand All @@ -48,7 +50,7 @@ commands =

[testenv:docs-lint]
description = run linter (rstcheck) to ensure there aren't errors on our docs
deps = -r{toxinidir}/requirements/docs-lint.txt
deps = -r{toxinidir}/requirements/docs.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need rstcheck?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's already in docs.txt -- so we should remove the docs-lint file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(removed in a commit)

changedir = {toxinidir}/docs
commands =
rstcheck -r .
Expand Down