-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use theme release 0.5.0rc1 for docs #7037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense w/ passing tests
The issue was a duplicate definition in If this works and we can't use sphinx 3.0.3 in code, then i'll make a mess of our requirements files to install Sphinx 3 after the docs requirements file. |
I'm getting a flash of a different font when I first load the docs, not sure whats going on there. |
Opened up readthedocs/sphinx_rtd_theme#913 to address this. The behavior seems to be prod docs produce invisible text while loading and 0.5.0rc1 uses the old behavior for unstyled text. |
* Upgrade Sphinx to 3.0.4 * Redo some of our doc requirements files to make them less complicated
55d6a0d
to
c0c02f1
Compare
I've rebased and i'm testing changes that separate docs dependencies from application dependencies. This is to work around the inability to upgrade docs Sphinx independent of the application Sphinx dependency. I've bumped to 0.5.0rc2 to fix some of the small issues with 0.5.0rc1 |
…agj/theme-0.5.0rc1
Believe we should ship this now right? |
@@ -48,7 +48,7 @@ commands = | |||
|
|||
[testenv:docs-lint] | |||
description = run linter (rstcheck) to ensure there aren't errors on our docs | |||
deps = -r{toxinidir}/requirements/docs-lint.txt | |||
deps = -r{toxinidir}/requirements/docs.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we still need rstcheck?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's already in docs.txt
-- so we should remove the docs-lint file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(removed in a commit)
@agjohnson looks like we have conflicting version issues, so I think that's why we had |
Actually -- I figured it out by hacking the install into the test command 👍 |
Shipping! |
Yeah, I separated docs from pip requirements because of this. We could add back this line eventually: But i'm not convinced that's the best pattern. I think your patch makes sense. I believe we can also do:
|
Yea, I tried that but it runs them both at the same time and conflicts, which is why I had to hack it. |
Also upgrade Sphinx to 3+