Pass the NO_COLOR env var to builder #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should let tools know that we don't want ANSI escaped colors in the output. Closes #6883
|
Alternatively, I'd love to have ansi control characters in the output that we could use to colorize the output. I'm not sure the best way to consome these, but it would be a huge UI win. |
|
I have a working implementation of ansi control character colorizing output, and i'm tracking revert of this PR. This PR can continue until we're closer on the template project. |
humitos
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should let tools know that we don't want ANSI escaped colors in
the output.
Closes #6883