Merge pull request #6981 from readthedocs/pass-no-color

Pass the NO_COLOR env var to builder
readthedocs · May 27, 2020 · b6650e6 · b6650e6
2 parents 4624b21 + 41e779c
commit b6650e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/readthedocs/projects/tasks.py b/readthedocs/projects/tasks.py
@@ -912,6 +912,9 @@ def get_env_vars(self):
         """Get bash environment variables used for all builder commands."""
         env = self.get_rtd_env_vars()
 
+        # https://no-color.org/
+        env['NO_COLOR'] = '1'
+
         if self.config.conda is not None:
             env.update({
                 'CONDA_ENVS_PATH': os.path.join(self.project.doc_path, 'conda'),

diff --git a/readthedocs/rtd_tests/tests/test_builds.py b/readthedocs/rtd_tests/tests/test_builds.py
@@ -349,6 +349,7 @@ def test_get_env_vars(self):
         task.config = mock.Mock(conda=None)
 
         env = {
+            'NO_COLOR': '1',
             'READTHEDOCS': 'True',
             'READTHEDOCS_VERSION': version.slug,
             'READTHEDOCS_PROJECT': project.slug,