Add Build managers and Update Build Querysets. #5779
Conversation
|
@saadmk11 Is it possible to have this PR have a base of |
|
@ericholscher github only allows to do that with branches in the same repo, not for forks. So, we could push the other branch to this repo to have that feature. |
|
Pushed them up, you can see it here: version-update...build-manager-update |
| @@ -116,7 +116,6 @@ def api(self, user=None, detail=True): | |||
|
|
|||
| class BuildQuerySet(SettingsOverrideObject): | |||
| _default_class = BuildQuerySetBase | |||
| _override_setting = 'BUILD_MANAGER' | |||
There was a problem hiding this comment.
We can't change this setting. We need to be able to still override this.
There was a problem hiding this comment.
@ericholscher actually we are now using BuildManager not BuildQueryset.as_manager() so i put this settings in the BuildManager.
https://github.com/rtfd/readthedocs.org/blob/3f93788ea69ad90c6230f4e9d19aae43a8428020/readthedocs/builds/managers.py#L176
saadmk11
force-pushed
the
build-manager-update
branch
from
3f93788 to
5607164
Compare
saadmk11
force-pushed
the
build-manager-update
branch
from
adfa2af to
de5ce44
Compare
saadmk11
removed
the
PR: work in progress
Follow up from readthedocs#5798
saadmk11
force-pushed
the
build-manager-update
branch
from
aa9bae6 to
5d6c750
Compare
saadmk11
force-pushed
the
gsoc-19-pr-builder
branch
from
05951cf to
5a05b6c
Compare
| # builds in the build list page | ||
| self.project_slug = self.kwargs.get('project_slug', None) | ||
| self.project = get_object_or_404( | ||
| Project.objects.protected(self.request.user), |
There was a problem hiding this comment.
We shouldn't used protected, let's just use public.
There was a problem hiding this comment.
@ericholscher This is default in the base class should we change this?
There was a problem hiding this comment.
@ericholscher This is default in the base class and we were using it should we change it?
|
Will merge this now, and we can fix up any issues later. |
This is a continuation of #5750.
Tasks:
BuildQuerysets withinternalandexternalmanagers everywhere.Managers