Version Model Update for Pull Request Builder

[saadmk11]

This PR will Update the Version Model to be used for Pull Request Builder.

Tasks:

• Add pull request VERSION_TYPES
• Update Version Model Methods
• Add Version Model Manager for internal and external Versions
• Add tests for Querysets

We need to think about how we want to create slugs for PR Versions. Should the slug be like this
pr-<number> or only <pr_number>. We have to think about how we can make pr version slugs unique so that it doesn't cause problems for the normal Versions. if we do pr-<number> the vcs_url() method of the Version Model needs to be updated.

Feel free to let me know if there are other places that we need to update for this PR.

I would like to get some initial feedback's to continue the work on slug creation and writing tests.

[stsewd]

We may want to use managers or another pattern, feels like a lot of places where we can forget to exclude PRs from the actual versions

[ericholscher]

Is this the normal way to handle this? Is it not normally project.versions.internal.filter?

[saadmk11]

yes this is the normal way to do this if we use multiple managers.
ref: Dajngo Docs

[ericholscher]

Looks good overall!

[ericholscher]

These options should be documented somewhere. Also we should be using constants for these, not strings INTERNAL = 'internal' in projects/constants.py or similar.

[saadmk11]

Okay I'll Add them in the constants. Do we Document Management Commands Somewhere?

[ericholscher]

Not currently -- perhaps we should do something like this: https://docs.readthedocs.io/en/latest/settings.html

[saadmk11]

Okay i'll Add these in another PR.

[stsewd]

We should check that Version.internal.public and Version.external.public is doing the filter correctly, because public can add all the versions ignoring any previous filter (see #5783)

[stsewd]

About the slug, doesn't matter what we choose, the slug is unique. We add prefixes to make a slug unique if there is one with that slug.

User creates a branch pr-200, the slug is created as pr-200, if a pull requests #200 is created the slug is pr-200_a.

[saadmk11]

We should check that Version.internal.public and Version.external.public is doing the filter correctly, because public can add all the versions ignoring any previous filter (see #5783)

@stsewd I have already added some tests. I'll add some more to be more careful.

About the slug, doesn't matter what we choose, the slug is unique. We add prefixes to make a slug unique if there is one with that slug.

User creates a branch pr-200, the slug is created as pr-200, if a pull requests #200 is created the slug is pr-200_a.

Then we have to add the prefix (pr-) for the External version slugs. how do you think we should handle vcs_url() ?

[stsewd]

In the version model we have identifier and verbose_name, I guess we are going to add the commit hash in identifier, and we can add the pr indentifier in verbose_name, this should be 123 (not pr-123) for github or anything that is used by the provider to identify a pr. That way is more easy to build the url

[ericholscher]

Closing this in favor of #5823, which should now be our feature branch for this work until it's merged into master.