Mark some BuildEnvironmentError exceptions as Warning and do not log them #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/build/log-exceptions
branch
from
be3dcd6 to
d6cc500
Compare
ericholscher
approved these changes
Aug 8, 2018
|
@humitos we just hit our limit again, we should fix the conflict here and ship it. |
There are some exceptions risen while building documentation that are considered an ERROR from the Build perspective, but for our application are just a WARNING and shouldn't be logged as ERROR (sent to Sentry). It's not an ERROR in our application but a WARNING that the user's documentation couldn't be built.
Note: the changes were selected manually since there were many that break the style that we want :(
humitos
force-pushed
the
humitos/build/log-exceptions
branch
from
7511411 to
29f1f65
Compare
|
Rebased the branch. Once the tests passed, I will merge it. |
|
This solves #3856? or we still need less logs? |
|
I don't think it 100% solves it, but at least reduce the noise. I'd like to get to the point to anything logged in Sentry requires manual/human attention. Currently, there are still lot of garbage there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some exceptions risen while building documentation that are considered an ERROR from the Build perspective, but for our application are just a WARNING and shouldn't be logged as ERROR (sent to Sentry).
It's not an ERROR in our application but a WARNING that the user's documentation couldn't be built.
This will help us to find Sentry more useful than it's right now as we are getting close to have logged only things that need human/dev attention.
Closes: #4109