Cleanup exception that are not logged as error

[humitos]

After #4495 got merged @agjohnson suggested to have an attribute in the Exception class and check for that attribute before log the exception, instead of defining a list for the warning exceptions as I did at:

https://github.com/rtfd/readthedocs.org/pull/4495/files#diff-ca52b098301dd315a834b3556ab9a7d5R424

Also, there are more exceptions that have to treat in the same way: ProjectConfigurationError for example.

https://sentry.io/read-the-docs/readthedocs-org/issues/668248681/

[agjohnson]

This is cleanup milestone, deprioritizing for now.

[humitos]

I think this is easier to do by defining Task.throws and using the proper Sentry setting SENTRY_CELERY_IGNORE_EXPECTED for this.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dojutsu-user]

@humitos
I think this can be closed now.

[stsewd]

I think we still need #5073 to close this

[stsewd]

This is still valid. We are logging manually those exceptions to sentry

readthedocs.org/readthedocs/doc_builder/environments.py

Lines 606 to 622 in 72972b5

	log_level_function(
	LOG_TEMPLATE,
	{
	'project': self.project.slug,
	'version': self.version.slug,
	'msg': exc_value,
	},
	exc_info=True,
	extra={
	'stack': True,
	'tags': {
	'build': self.build.get('id'),
	'project': self.project.slug,
	'version': self.version.slug,
	},
	},
	)

From projects/tasks.py we are re-raising some exceptions to don't fall into the genereal Exception block and don't log those (#6112).

And we haven't removed the old code :)

readthedocs.org/readthedocs/doc_builder/environments.py

Lines 536 to 542 in 72972b5

	WARNING_EXCEPTIONS = (
	VersionLockedError,
	ProjectBuildsSkippedError,
	YAMLParseError,
	BuildTimeoutError,
	MkDocsYAMLParseError,
	)

There is no way to fix this using throws on the task. And we can't re-raise the exception because that will break many places.

And using the BuildEnviroment should know nothing about the exception on WARNING_EXCEPTIONS. So, we could pass on the BuildEnvironment constructor an arg like ignore_exceptions=() with all classes that we want to be ignored. Or Just remove the code that manually logs those errors and each part that uses a buildenviroment should be in charge of catching those, buildenviroment will only handle BuildEnvironmentWanings.

[ericholscher]

I feel like this is now solved. Re-open it if not 👍