Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MkDocs yaml issue with custom_dir theme option comment #4302

Closed
wants to merge 1 commit into from
Closed

MkDocs yaml issue with custom_dir theme option comment #4302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions readthedocs/doc_builder/backends/mkdocs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,11 @@ def get_theme_name(self, mkdocs_config):
# Full nested theme config (the new configuration)
return theme_setting.get('name') or self.READTHEDOCS_THEME_NAME

# TODO: this is not the same behavior than before. Now, with a theme:
# custom_dir: citrix it will return `readthedocs` while previously it
# was returning the theme_dir as theme_name:
# https://github.com/rtfd/readthedocs.org/commit/538413cf9f31be96c09f7c44e4832561cd00b0d9#diff-ccc6f61d1c02f524ab7362ee8749ba4bL125

if theme_setting:
# A string which is the name of the theme
return theme_setting
Expand Down