Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MkDocs yaml issue with custom_dir theme option comment #4302

Closed
wants to merge 1 commit into from

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 26, 2018

This is not a real PR but a way to mark in the code where the problem is and do not forget about this issue. Although, Maybe is a non-issue.

Just want to reflect that the behavior changed in this PR #4041 and it could affect some configs at some point.

I found this while researching about a project with a custom MkDocs theme where the content of the output was not included with MkDocs 0.17 but it was with 0.15

@davidfischer
Copy link
Contributor

Just to clarify here, this problem occurs when somebody is following the old deprecated way to specify a theme directory but using the latest MkDocs. If they use theme_dir it should be ok, right (538413c#diff-ccc6f61d1c02f524ab7362ee8749ba4bR202)?

This problem occurs when somebody has a config like:

theme:
    custom_dir: mytheme
    # no theme name

Correct?

@ericholscher
Copy link
Member

Has this been fixed w/our recent mkdocs doc updates?

@ericholscher
Copy link
Member

@humitos ^^? Can this be closed?

@ericholscher
Copy link
Member

Closing, as I believe this issue has been addressed elsewhere.

@humitos
Copy link
Member Author

humitos commented Nov 7, 2018

I'm sorry. I had not a chance to take a look at this again and make the proper QA.

We didn't have any new report around mkdocs with this issue in the end and I'm fine closing this.

@stsewd stsewd deleted the humitos/mkdocs/theme-config branch November 7, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants