Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove description field from project forms and display #3754

Closed
wants to merge 3 commits into from

Conversation

bansalnitish
Copy link
Contributor

@bansalnitish bansalnitish commented Mar 8, 2018

Fixes #3689
This PR removes project description field from project import form, project settings form and project detail display.

@bansalnitish bansalnitish force-pushed the desc-rm branch 2 times, most recently from 28e0eb7 to a0f4109 Compare March 8, 2018 19:36
@stsewd
Copy link
Member

stsewd commented Mar 8, 2018

...and add version listing with build details

I think this part is already addressed on #3673

@bansalnitish
Copy link
Contributor Author

@stsewd PR #3673 is providing a different UI for version listing but this one is providing a vertical listing with information on the build date and state as well after removal of the description field (as in the screenshot).

@stsewd
Copy link
Member

stsewd commented Mar 8, 2018

@bansalnitish this will conflict with #3673 which solve #3554. As general recommendation is better to keep the changes related to the issue that the PR is solving, anything else you can create a new issue if you consider or in this case make the suggestion on #3673.

@bansalnitish
Copy link
Contributor Author

bansalnitish commented Mar 8, 2018

Actually, I made these changes as per the suggestions here: #3689 (comment)
Shall I revert them?

@agjohnson
Copy link
Contributor

Thanks for taking this on @bansalnitish !

#3689 is just the first step to making the dashboard page more usable. We're not yet ready to say what we want the front page version listing to be, so I'd rather avoid a redesign of this interface.

Perhaps start with just addressing #3689 here. My notes on what we want the listing to look like only tried to answer the question of whether we could replace the description field with more helpful content. We'll need a design process for the interface changes separately, but this will likely take a little while to form opinions on.

@bansalnitish
Copy link
Contributor Author

Okay @agjohnson

@agjohnson
Copy link
Contributor

@bansalnitish #3689 has progressed from a design decision state, so feel free to read that through for an update on our thoughts here. I've updated the ticket description with the points we'd like to address.

A UI update is still a ways off, so that can be broken out of this PR

@bansalnitish bansalnitish changed the title Remove description field and add version listing with build details Remove description field from project forms and display Mar 12, 2018
@bansalnitish
Copy link
Contributor Author

bansalnitish commented Mar 12, 2018

Hi @agjohnson, I have updated this PR according to the description in issue #3689!

@ericholscher
Copy link
Member

Are we still happy with this implementation? I'm +1 on merging & deploying it.

@stsewd stsewd added the PR: work in progress Pull request is not ready for full review label Nov 21, 2018
@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stale stale bot closed this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: work in progress Pull request is not ready for full review Status: stale Issue will be considered inactive soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants