Better version listing for project dashboard #3673

shubham76 · 2018-02-24T05:21:28Z

This PR is regarding Issue #3554.
First 4 out of 5 requirements.
Please correct me if I made any mistakes.

The file was changed by mistake. Restored it.

stsewd · 2018-02-24T17:40:58Z

readthedocs/templates/core/project_detail_right.html

@@ -91,6 +91,15 @@ <h3>{% trans "Project Privacy Level" %}</h3>
  </div>
 {% endblock %}

+{% block project-default-branch %}
+  <h3>{% trans "Project Default Branch" %}{# trans does not work here. #}</h3>


Why that comment {# trans does not work here. #}?

{% trans "Project Default Branch" %}
The language for this should change when we change the website language. But somehow it doesn't know the right word for 'Default' in other languages and therefore it stays in English language only. I couldn't figure out why that happens. That's why I wrote the comment.
Should I remove the comment?

that's because of missing translations for that word, RTD uses transifex for collaborating on i18n https://docs.readthedocs.io/en/latest/i18n.html. It's safe to remove that comment.

Oh. Okay! I will remove the comment.

stsewd · 2018-02-24T19:26:59Z

readthedocs/templates/core/project_details.html

@@ -19,40 +19,42 @@
    <h3>{% trans "Versions" %}</h3>
  </div>

-  <div class="module-list">


I think this div is still needed, can you post a screenshot of how it looks?

Because of removing that div it looks like the version page listing.
What do you think?

Actually, rtd is moving to match the previous style on all lists (see #3445 (comment))

But the issue #3554 here says it should match the style on project version listing page.
What should be done?

I'm not sure, lets wait to agjohnson's reply, but on other issue this was already discussed (see #3572, relevant comments: #3572 (comment), #3572 (comment))

Yes. I saw that. I still went ahead with this issue as there were other improvements as well.
I hope that's fine. :)

The styling that was removed here was indeed the correct styling, it should be added back. The styling wasn't the issue, but the table content. We're also missing an opportunity to have a single template for 3 different pages, so that is the larger focus here.

Oh! In that case, the previous design should remain same. Got it! I'll change the styling back again and keep the table content modified as it is in PR.

stsewd · 2018-02-25T05:25:28Z

readthedocs/templates/core/project_details.html

+        {# Link to the docs #}
+        <a class="module-item-title" href="{{ version.get_absolute_url }}">
+          {{ version.slug }}
+        {% if request.user in project.users.all %}


You can use {% if request.user|is_admin:project %} for checking for the right user. You will need to load this tag {% load privacy_tags %} (if itsn't already loaded)

Yes. Right. I'll make the changes straight away.

stsewd · 2018-02-25T05:27:33Z

readthedocs/templates/core/project_detail_right.html

@@ -91,6 +91,15 @@ <h3>{% trans "Project Privacy Level" %}</h3>
  </div>
 {% endblock %}

+{% block project-default-branch %}
+  <h3>{% trans "Project Default Branch" %}</h3>


From #3554

The front dashboard page version listing should note the default branch

I think this info should go on the list, not on the side bar.

Oh Yes. I thought so. But I wasn't clear about the requirement.
It is there on the list as shown in the picture.
Should I remove these lines then?

👍 on default version noted in the table, not the sidebar.

agjohnson · 2018-02-27T08:06:02Z

The other piece to this work is to make the version lists a single template, so that we aren't duplicating patterns in two different places. There could be some element that don't fit, and perhaps that can be handled conditionally through a variable passed to the template include.

agjohnson · 2018-02-27T08:06:49Z

Also, this will conflict with #3445, which fixes some of the style level problems with the version page.

shubham76 · 2018-03-02T09:42:26Z

Thanks for the review @agjohnson!

The other piece to this work is to make the version lists a single template, so that we aren't duplicating patterns in two different places. There could be some element that don't fit, and perhaps that can be handled conditionally through a variable passed to the template include.

Okay. So we need a single Django-template to insert into project_details.html & project_version_list.html so we don't have to repeat the code. Is that correct?

Also, this will conflict with #3445, which fixes some of the style level problems with the version page.

Oh. Actually, I am new to the open source. What should be done in that case?

stsewd · 2018-03-02T16:55:36Z

What should be done in that case?

@shubham76 if your changes cross to much, I think the best is to wait to #3445 to gets merged. If not, feel free to continue!

shubham76 · 2018-03-03T05:17:13Z

@stsewd Okay. Thanks for replying! :)

bansalnitish · 2018-03-03T19:35:22Z

readthedocs/templates/core/project_details.html

@@ -18,9 +18,9 @@
  <div class="module-header">
    <h3>{% trans "Versions" %}</h3>
  </div>
-
+  


Remove Extra spaces !

Well, it has been like that in the original code. https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/templates/core/project_details.html. I did not try to change that style.

The line is fine. I am referring to the extra whitespace you have added. It was not in the original code.

bansalnitish · 2018-03-03T19:35:31Z

readthedocs/templates/core/project_details.html

  <div class="module-list">
-
+    


humitos · 2018-10-10T09:13:21Z

Hi all! What's the status of this PR?

I think it was "kind of blocked" on #3445 which was already merged. So, I suppose that you can rebase it and use the styles that PR introduces.

ericholscher · 2018-11-02T03:28:03Z

Closing this, as it hasn't been updated in a few months. Feel free to reopen with requested changes.

Better version listing for project dashboard - Issue: #3554

6ba8cab

shubham76 changed the title ~~Better version listing for project dashboard - Issue: #3554~~ Better version listing for project dashboard Feb 24, 2018

restored projects/views/public.py

3d2747c

The file was changed by mistake. Restored it.

stsewd reviewed Feb 24, 2018

View reviewed changes

Removed the extra comment

15f3edd

stsewd reviewed Feb 24, 2018

View reviewed changes

stsewd reviewed Feb 25, 2018

View reviewed changes

made changes to check the right user

7d0e431

shubham76 added 3 commits February 27, 2018 22:12

Removed default branch name from the right side-bar

4877aa3

Reverted the project detail table styling

bd67955

Update project_details.html

d3d00d0

RichardLitt added the PR: work in progress Pull request is not ready for full review label Mar 2, 2018

bansalnitish reviewed Mar 3, 2018

View reviewed changes

removed extra spaces

28b9af2

stsewd mentioned this pull request Mar 8, 2018

Remove description field from project forms and display #3754

Closed

ericholscher closed this Nov 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better version listing for project dashboard #3673

Better version listing for project dashboard #3673

shubham76 commented Feb 24, 2018 •

edited

Loading

stsewd Feb 24, 2018

shubham76 Feb 24, 2018 •

edited

Loading

stsewd Feb 24, 2018

shubham76 Feb 24, 2018

stsewd Feb 24, 2018

shubham76 Feb 25, 2018 •

edited

Loading

stsewd Feb 25, 2018

shubham76 Feb 25, 2018

stsewd Feb 25, 2018 •

edited

Loading

shubham76 Feb 25, 2018

agjohnson Feb 27, 2018

shubham76 Feb 28, 2018

stsewd Feb 25, 2018

shubham76 Feb 25, 2018

stsewd Feb 25, 2018

shubham76 Feb 25, 2018

agjohnson Feb 27, 2018

agjohnson commented Feb 27, 2018

agjohnson commented Feb 27, 2018

shubham76 commented Mar 2, 2018

stsewd commented Mar 2, 2018

shubham76 commented Mar 3, 2018

bansalnitish Mar 3, 2018

shubham76 Mar 4, 2018 •

edited

Loading

bansalnitish Mar 4, 2018 •

edited

Loading

bansalnitish Mar 3, 2018

humitos commented Oct 10, 2018

ericholscher commented Nov 2, 2018

Better version listing for project dashboard #3673

Better version listing for project dashboard #3673

Conversation

shubham76 commented Feb 24, 2018 • edited Loading

Choose a reason for hiding this comment

shubham76 Feb 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubham76 Feb 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stsewd Feb 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agjohnson commented Feb 27, 2018

agjohnson commented Feb 27, 2018

shubham76 commented Mar 2, 2018

stsewd commented Mar 2, 2018

shubham76 commented Mar 3, 2018

Choose a reason for hiding this comment

shubham76 Mar 4, 2018 • edited Loading

Choose a reason for hiding this comment

bansalnitish Mar 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

humitos commented Oct 10, 2018

ericholscher commented Nov 2, 2018

shubham76 commented Feb 24, 2018 •

edited

Loading

shubham76 Feb 24, 2018 •

edited

Loading

shubham76 Feb 25, 2018 •

edited

Loading

stsewd Feb 25, 2018 •

edited

Loading

shubham76 Mar 4, 2018 •

edited

Loading

bansalnitish Mar 4, 2018 •

edited

Loading