Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #1612 #2927

Merged
merged 1 commit into from
Jun 13, 2017
Merged

fix for #1612 #2927

merged 1 commit into from
Jun 13, 2017

Conversation

jonasrauber
Copy link
Contributor

using the never_cache decorator should set Expires to now

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, this looks good. Perhaps it would be a good idea to add a test that expects the Expire header?

@agjohnson
Copy link
Contributor

Oh also, test failure is a broken testing dependency. Feel free to rebase on #2932 or just leave the failure. We will just need to make sure no linting problems are introduced here.

using the never_cache decorator should set `Expires` to now
@jonasrauber
Copy link
Contributor Author

rebased on master

@ericholscher
Copy link
Member

Thanks!

@ericholscher ericholscher merged commit 4cddf5b into readthedocs:master Jun 13, 2017
@jonasrauber
Copy link
Contributor Author

When will this be deployed in production?

@ericholscher
Copy link
Member

ericholscher commented Jun 18, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants