-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub aggressively caches status badges: need HTTP headers to prevent it. #1612
Comments
Agreed, we should be doing this. If we can't do this in the badge view, we can do it in the production environment. |
+1 on this one |
Possible fix: #1653 |
I'm still affected by this issue even though the code has been merged. |
Same here... Edit: When I try to open the link in the browser (e.g. https://readthe.../badge/?version=latest), I get a url redirection (302 Found) and the image from img.shields.io. However, there the Cache-Control header is not set correctly ("public, max-age=86400"). |
+1 to this issue. |
This problem still exists. According to
|
using the never_cache decorator should set `Expires` to now
I created a pull-request to fix this: #2927 |
using the never_cache decorator should set `Expires` to now
Pass on the `maxAge` query parameter when redirecting to the badge image from Shields.io. This should help with GitHub's unwanted badge caching. The default is 1 day.
Should be fixed by #3005 👍 |
I'm still seeing this issue. To reproduce:
|
I am also still seeing this issue with my School Project Repo. The builds were failing, they were fixed about 3 days ago, but the failing badge still persists. |
My "docs status" badge is stuck on red, because GitHub caches them. Here's the GitHub issue discussing the caching headers needed: github/markup#224 I'm not sure rtfd's redirect to shields.io affects things.
The text was updated successfully, but these errors were encountered: