Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to GitHub include 'origin' and thus are broken #5518

Closed
paulmeems-waterwatchfoundation opened this issue Mar 21, 2019 · 3 comments
Closed
Assignees
Labels
Bug A bug

Comments

@paulmeems-waterwatchfoundation

Details

I'm facing the same problem as mentioned in #3203
That issue is closed.

Expected Result

I expect the 'Edit on GitHub' to be
https://github.com/globalcoffeeplatform/CoffeeDataStandard/blob/master/docs/source/index.rst
Without the 'origin' part.
A description of what you wanted to happen

Actual Result

Now the link is
https://github.com/globalcoffeeplatform/CoffeeDataStandard/blob/origin/master/docs/source/index.rst

A description of what actually happened
I've rebuild several times. Perhaps I need a different version of some tool?
I'm using Spinx v1.8.4 and sphinx-rtd-theme v0.4.2

@stsewd
Copy link
Member

stsewd commented Mar 21, 2019

I'm not really sure why we put the origin there, but you can solve this problem in the meantime going to your project's advanced settings, the default branch setting will be filled with master, you just need to change it to blank (which is basically the same as master) and click save.

@stsewd stsewd added the Bug A bug label Mar 21, 2019
@paulmeems-waterwatchfoundation
Copy link
Author

Thanks @stsewd your workaround works.

@stsewd stsewd self-assigned this Mar 22, 2019
@stsewd
Copy link
Member

stsewd commented Mar 22, 2019

stsewd added a commit to stsewd/readthedocs.org that referenced this issue Mar 22, 2019
`verbose_name` is unique in each project, because we only have one remote.
`identifier` includes origin for branches and also it can point to the
same commit in tags.

Fixes readthedocs#5518
jeromegamez added a commit to kreait/firebase-php that referenced this issue Aug 1, 2019
Using "master" seems to mess it up, see
readthedocs/readthedocs.org#5518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants