Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github link broken on https://mypy.readthedocs.io #8285

Closed
etnnth opened this issue Jan 15, 2020 · 6 comments
Closed

github link broken on https://mypy.readthedocs.io #8285

etnnth opened this issue Jan 15, 2020 · 6 comments
Labels

Comments

@etnnth
Copy link

etnnth commented Jan 15, 2020

The github link given by 'Edit on GitHub' on top right of https://mypy.readthedocs.io links to :
https://github.com/python/mypy/blob/origin/master/docs/source/index.rst instead of :
https://github.com/python/mypy/blob/master/docs/source/index.rst](https://github.com/python/mypy/blob/master/docs/source/index.rst).
The same also append for github link on the bottom left.

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 16, 2020

Yeah, the link is broken. I wonder what is going on. Does anybody know how readthedocs is configured?

@JukkaL JukkaL added bug mypy got something wrong documentation priority-0-high labels Jan 16, 2020
@TH3CHARLie
Copy link
Collaborator

Maybe try this readthedocs/readthedocs.org#5518 (comment)

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 17, 2020

Thanks! It seems to work now when I toggled the settings mentioned in the comment to 'master' and back. Can somebody else verify that it works?

@TH3CHARLie
Copy link
Collaborator

It is not broken anymore but points to a strange commit like https://github.com/python/mypy/blob/f53b718bdf5935443332a43d8c1b448af8b80b57/docs/source/index.rst

@etnnth
Copy link
Author

etnnth commented Jan 17, 2020

It looks fine for me, this is the last commit of the last release.

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 17, 2020

I also (separately) changed readthedocs to point to the last stable release, so everything seems fine.

@JukkaL JukkaL closed this as completed Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants