Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reducer): quirk with security schemes sometimes getting removed #867

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 18, 2023

🚥 Resolves #860

🧰 Changes

  • Upgrades oas to 20.10.2 to resolve a quirk with the openapi:reducer command where if you had an API definition with a root-level security configuration the corresponding securityScheme for that wouldn't be retained in the reduced OpenAPI definition, resulting in a definition that does not pass validation.

@erunion erunion added bug Something isn't working command:openapi Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands labels Aug 18, 2023
@erunion erunion requested a review from kanadgupta August 18, 2023 22:45
@erunion erunion marked this pull request as ready for review August 18, 2023 22:45
@kanadgupta kanadgupta merged commit be2e037 into next Aug 18, 2023
@kanadgupta kanadgupta deleted the fix/bump-reducer branch August 18, 2023 22:48
kanadgupta pushed a commit that referenced this pull request Aug 18, 2023
## [8.6.5-next.7](v8.6.5-next.6...v8.6.5-next.7) (2023-08-18)

### Bug Fixes

* **reducer:** quirk with security schemes sometimes getting removed ([#867](#867)) ([be2e037](be2e037))

[skip ci]
kanadgupta pushed a commit that referenced this pull request Aug 21, 2023
## [8.6.5](v8.6.4...v8.6.5) (2023-08-21)

### Bug Fixes

* **deps:** upgrading out of date deps ([#836](#836)) ([8600554](8600554))
* **npm:** revert shrinkwrap changes ([#824](#824)) ([f96e6dc](f96e6dc))
* **openapi/inspect:** small url formatting error ([#855](#855)) ([c54e289](c54e289))
* **reducer:** quirk with security schemes sometimes getting removed ([#867](#867)) ([be2e037](be2e037))
* **security:** don't publish certain files to npm ([a83fe1c](a83fe1c)), closes [/socket.dev/npm/package/rdme/files/8.6.5-next.2/bin/docker.js#T167-182](https://github.com//socket.dev/npm/package/rdme/files/8.6.5-next.2/bin/docker.js/issues/T167-182)
* typo ([#852](#852)) ([26c10e5](26c10e5))
* **versions:** general refactors to handle flag edge cases ([#861](#861)) ([e316139](e316139))

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command:openapi Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

securityScheme not included in reduced API definition
2 participants