fix(openapi/inspect): small url formatting error #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
bug
kanadgupta
pushed a commit
that referenced
this pull request
Aug 10, 2023
## [8.6.5-next.5](v8.6.5-next.4...v8.6.5-next.5) (2023-08-10) ### Bug Fixes * **openapi/inspect:** small url formatting error ([#855](#855)) ([c54e289](c54e289)) [skip ci]
kanadgupta
pushed a commit
that referenced
this pull request
Aug 21, 2023
## [8.6.5](v8.6.4...v8.6.5) (2023-08-21) ### Bug Fixes * **deps:** upgrading out of date deps ([#836](#836)) ([8600554](8600554)) * **npm:** revert shrinkwrap changes ([#824](#824)) ([f96e6dc](f96e6dc)) * **openapi/inspect:** small url formatting error ([#855](#855)) ([c54e289](c54e289)) * **reducer:** quirk with security schemes sometimes getting removed ([#867](#867)) ([be2e037](be2e037)) * **security:** don't publish certain files to npm ([a83fe1c](a83fe1c)), closes [/socket.dev/npm/package/rdme/files/8.6.5-next.2/bin/docker.js#T167-182](https://github.com//socket.dev/npm/package/rdme/files/8.6.5-next.2/bin/docker.js/issues/T167-182) * typo ([#852](#852)) ([26c10e5](26c10e5)) * **versions:** general refactors to handle flag edge cases ([#861](#861)) ([e316139](e316139)) [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Noticed a tiny formatting error when running
openapi:inspectagainst an OpenAPI 3.0 definition:I made the type a little stricter and tweaked the logic a bit so now it looks like this:
I don't love how the URL and this disclaimer text have the same formatting, but this is probably good enough for now.
🧬 QA & Testing
Do tests pass and does this change look good?