Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gha-onboarding): don't run git commands in CI #657

Merged
merged 4 commits into from
Nov 1, 2022

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Nov 1, 2022

🧰 Changes

This makes a small change to our GitHub Actions onboarding logic so we never execute git commands if a CI environment is detected.

Hopefully fixes #649.

🧬 QA & Testing

Do tests pass and do these changes make sense?

@kanadgupta kanadgupta added bug Something isn't working GHA / CI Issues specific to GitHub Actions or other CI environments github actions and removed github actions labels Nov 1, 2022
@kanadgupta kanadgupta marked this pull request as ready for review November 1, 2022 16:24
@kanadgupta kanadgupta requested a review from erunion November 1, 2022 16:25
@kanadgupta kanadgupta merged commit a3955f2 into main Nov 1, 2022
@kanadgupta kanadgupta deleted the fix/git-commands-in-CI branch November 1, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GHA / CI Issues specific to GitHub Actions or other CI environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing with "fatal: could not read Username for 'https://github.com'" after 8.0.0 release
2 participants