failing with "fatal: could not read Username for 'https://github.com'" after 8.0.0 release

[david-wolgemuth]

hello,

our CI started failing after the 8.0.0 release today while running:

npx --yes rdme docs $PATH --version=$VERSION --key=$KEY

giving the following output:

git: 'credential-gcloud.sh' is not a git command. See 'git --help'.
fatal: could not read Username for 'https://github.com': No such device or address

(running within Google Cloud Build, which is why I assume it is looking for credential-gcloud.sh)

we pinned it back to 7.x for the time being, not sure the context around rdme using git

[kanadgupta]

Hi @david-wolgemuth, apologies for the trouble. As of v8.0, we use git commands to determine whether or not to run a GitHub Actions onboarding workflow. I have a theory for what could be going on here and I'll open up a PR shortly.

Out of curiosity, could you confirm if your CI setup uses one of the environmental variables mentioned in this list (e.g., BUILDER_OUTPUT or CI)? We use this for detecting CI environments. I see Google Cloud Builder mentioned in that list, but I'm not super familiar with the Google Cloud ecosystem.

[david-wolgemuth]

Thanks for the quick turnaround @kanadgupta , looking at that lib, it seems GCP sets almost nothing.. We can manually export CI=true 👍

https://github.com/npm/ci-detect/blob/995830e84f7aff0ff1d5e3135773f7561b390367/lib/index.js#L50-L51

[kanadgupta]

Sounds good @david-wolgemuth! v8.0.1 is now released with a potential fix. Let me know if that addresses the issue — ideally we shouldn't require folks using GCP to manually export a variable like that.