fix(GHA): remove chalk overrides from error annotations
#466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
changed the title
chalk overrides from error annotations
erunion
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Much to my annoyance, there's some issues where the GitHub Actions annotations don't process ANSI escape codes created by
chalkproperly (even though they claim to support them), resulting in messy error messages that look like this:The only fix I've found is to disable
chalkentirely, which removes colors from the logs but results in cleaner error messages at least:See below for example links for all the possible
FORCE_COLORvalue results (scroll down to the Annotations section):FORCE_COLORvalue: https://github.com/readmeio/rdme/actions/runs/1930104181FORCE_COLOR=0: https://github.com/readmeio/rdme/actions/runs/1930104858FORCE_COLOR=1: https://github.com/readmeio/rdme/actions/runs/1930102539FORCE_COLOR=2: https://github.com/readmeio/rdme/actions/runs/1930096421FORCE_COLOR=3: https://github.com/readmeio/rdme/actions/runs/1930097694I also tried different interpolations and bypassing
@actions/core, but nothing appeared to do the trick. I figured we should just not override the color anymore and hope that GitHub Actions fixes their shit.🧬 QA & Testing
Do tests pass? 🤷🏽♂️
Fixes RM-3725