Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: making the docs command recursive by default #343

Merged
merged 4 commits into from
Jul 28, 2021
Merged

feat: making the docs command recursive by default #343

merged 4 commits into from
Jul 28, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Jul 27, 2021 •
edited
Loading

🧰 Changes

  • Slightly alters the --recursive argument introduced in Add --recursive option to doc sync command #313 to make the docs command recursive by default, always.
  • Updating our docs test to test recursive doc directory syncing.
  • Some general tidying up of the docs command to remove things that might look like internal IDs or API keys.

🧬 QA & Testing

  • Tests pass?

@erunion erunion added the enhancement New feature or request label Jul 27, 2021
@erunion erunion marked this pull request as draft July 27, 2021 21:55
@erunion erunion marked this pull request as ready for review July 27, 2021 22:44
rahulhegdee
rahulhegdee suggested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@rahulhegdee rahulhegdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a small change to bring back functionality, but otherwise LGTM!

__tests__/cmds/docs.test.js Show resolved Hide resolved
src/cmds/docs/index.js Show resolved Hide resolved
@erunion erunion requested a review from rahulhegdee July 28, 2021 01:02
@erunion erunion merged commit a7a5caa into main Jul 28, 2021
@erunion erunion deleted the feat/make-docs-recursive-by-default branch July 28, 2021 02:35
@kanadgupta kanadgupta mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulhegdee rahulhegdee rahulhegdee approved these changes

@kanadgupta kanadgupta Awaiting requested review from kanadgupta

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @rahulhegdee