Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --recursive option to doc sync command #313

Merged
merged 9 commits into from
Jul 9, 2021

Conversation

ollyfg
Copy link
Contributor

@ollyfg ollyfg commented May 25, 2021

This option causes a simple recursive search of the supplied folder, nothing fancy.

ollyfg added 2 commits May 25, 2021 14:47
This option causes a simple recursive search of the supplied folder.
@erunion erunion self-requested a review May 25, 2021 16:32
@erunion
Copy link
Member

erunion commented Jun 21, 2021

@ollyfg Can you rebase the latest main into this branch? We've moved some things around in the process of dropping support for Node 10.

erunion added 3 commits June 22, 2021 15:51
…eadmeio#325)

* feat: dropping support for node 10

* test: fixing a broken test on node 14

* ci: updating the ci workflow to use node 12+

* ci: upgrading the codeql workflow to the latest way it configs

* chore(deps-dev): upgrading jest to v27

* chore(deps-dev): upgrading code styling dev deps

* chore(deps-dev): upgrading nock to the latest version

* chore: removing a swagger file that shouldnt be in the root dir?

* ci: updating codeql to run on `main` not `master`

* fix: removing the `main` declaration because it doesnt exist
* feat: dropping support for node 10

* test: fixing a broken test on node 14

* ci: updating the ci workflow to use node 12+

* ci: upgrading the codeql workflow to the latest way it configs

* chore(deps-dev): upgrading jest to v27

* chore(deps-dev): upgrading code styling dev deps

* chore(deps-dev): upgrading nock to the latest version

* chore: removing a swagger file that shouldnt be in the root dir?

* ci: updating codeql to run on `main` not `master`

* chore: updating the license to be 2021

* chore: renaming the test directory to `__tests__`

* chore: various dotfile cleanup

* chore: moving the codebase into a `src/` directory structure
@erunion erunion requested a review from rahulhegdee June 23, 2021 15:55
@erunion
Copy link
Member

erunion commented Jun 23, 2021

@rahulhegdee This might collide with the work that you're planning on doing, you mind reviewing this? ty

Copy link
Contributor

@rahulhegdee rahulhegdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix but otherwise, looks good to me!

src/cmds/docs/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@rahulhegdee rahulhegdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erunion erunion added the enhancement New feature or request label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants