Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrading out of date deps #836

Merged
merged 4 commits into from
Jul 5, 2023
Merged

chore(deps): upgrading out of date deps #836

merged 4 commits into from
Jul 5, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Jul 1, 2023 •
edited by kanadgupta
Loading

🧰 Changes

Before

Package                          Current  Wanted  Latest  Location                                      Depended by
@commitlint/cli                   17.6.5  17.6.6  17.6.6  node_modules/@commitlint/cli                  rdme
@commitlint/config-conventional   17.6.5  17.6.6  17.6.6  node_modules/@commitlint/config-conventional  rdme
@readme/eslint-config             10.6.0  10.6.1  10.6.1  node_modules/@readme/eslint-config            rdme
chalk                              4.1.2   4.1.2   5.3.0  node_modules/chalk                            rdme
configstore                        5.0.1   5.0.1   6.0.0  node_modules/configstore                      rdme
eslint                            8.42.0  8.44.0  8.44.0  node_modules/eslint                           rdme
jest                              29.5.0  29.6.0  29.6.0  node_modules/jest                             rdme
jest-extended                      3.2.4   3.2.4   4.0.0  node_modules/jest-extended                    rdme
node-fetch                        2.6.11  2.6.12   3.3.1  node_modules/node-fetch                       rdme
oas                               20.8.4  20.8.7  20.8.7  node_modules/oas                              rdme
open                               8.4.2   8.4.2   9.1.0  node_modules/open                             rdme
ora                                5.4.1   5.4.1   6.3.1  node_modules/ora                              rdme
prettier                           2.8.8   2.8.8   3.0.0  node_modules/prettier                         rdme
semver                             7.5.1   7.5.3   7.5.3  node_modules/semver                           rdme
simple-git                        3.19.0  3.19.1  3.19.1  node_modules/simple-git                       rdme
ts-jest                           29.1.0  29.1.1  29.1.1  node_modules/ts-jest                          rdme
type-fest                         3.11.1  3.12.0  3.12.0  node_modules/type-fest                        rdme
typescript                         5.1.3   5.1.6   5.1.6  node_modules/typescript                       rdme

After

Package      Current  Wanted  Latest  Location                  Depended by
chalk          4.1.2   4.1.2   5.3.0  node_modules/chalk        rdme
configstore    5.0.1   5.0.1   6.0.0  node_modules/configstore  rdme
node-fetch    2.6.12  2.6.12   3.3.1  node_modules/node-fetch   rdme
open           8.4.2   8.4.2   9.1.0  node_modules/open         rdme
ora            5.4.1   5.4.1   6.3.1  node_modules/ora          rdme
prettier       2.8.8   2.8.8   3.0.0  node_modules/prettier     rdme

@erunion erunion added the dependencies Pull requests that update a dependency file label Jul 1, 2023
@erunion erunion requested a review from kanadgupta July 1, 2023 16:30
@erunion
Copy link
Member Author

erunion commented Jul 3, 2023

Looks like the eslint-plugin-jest-dom is no longer getting installed on Node 14. Maybe it's okay to stop linting on Node 14 since it's EOL?

@kanadgupta
Copy link
Member

kanadgupta commented Jul 5, 2023 •
edited
Loading

@erunion it looks like eslint-plugin-jest-dom made @testing-library/dom a required peer dep when bumping to v5: https://github.com/testing-library/eslint-plugin-jest-dom/releases/tag/v5.0.0

I'm guessing there's something about the dep resolution in npm@7 and above where they automatically handle this, so thoughts on bringing in @testing-library/dom into the fold in @readme/eslint-config? If @readme/eslint-config wasn't a mostly internal library I'd argue that this is technically a breaking change since it evidently requires npm@7 and above.

@erunion
Copy link
Member Author

erunion commented Jul 5, 2023

Ah that's happening because Node 14 still ships NPM 6 which doesn't install peerDeps by default. They changed that with NPM 7. What if we did an if block in the CI workflow for Node 14 to install NPM 7?

This was referenced Jul 5, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
kanadgupta
kanadgupta approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@kanadgupta kanadgupta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erunion ended up getting it working by backfilling the @testing-library/dom peerdep. I like this approach better since I don't want us to have to deal with possible installation issues for Node 14 users and forcing them to upgrade their npm version. Merging!

@kanadgupta kanadgupta merged commit 8600554 into next Jul 5, 2023
@kanadgupta kanadgupta deleted the chore/bump-deps branch July 5, 2023 18:43
kanadgupta pushed a commit that referenced this pull request Jul 5, 2023
@semantic-release-bot
build(release): 🚀 v8.6.5-next.2 🦉
78c505e 
## [8.6.5-next.2](v8.6.5-next.1...v8.6.5-next.2) (2023-07-05)

### Bug Fixes

* **deps:** upgrading out of date deps ([#836](#836)) ([8600554](8600554))

[skip ci]
kanadgupta pushed a commit that referenced this pull request Aug 21, 2023
@semantic-release-bot
build(release): 🚀 v8.6.5 🦉
92df44f 
## [8.6.5](v8.6.4...v8.6.5) (2023-08-21)

### Bug Fixes

* **deps:** upgrading out of date deps ([#836](#836)) ([8600554](8600554))
* **npm:** revert shrinkwrap changes ([#824](#824)) ([f96e6dc](f96e6dc))
* **openapi/inspect:** small url formatting error ([#855](#855)) ([c54e289](c54e289))
* **reducer:** quirk with security schemes sometimes getting removed ([#867](#867)) ([be2e037](be2e037))
* **security:** don't publish certain files to npm ([a83fe1c](a83fe1c)), closes [/socket.dev/npm/package/rdme/files/8.6.5-next.2/bin/docker.js#T167-182](https://github.com//socket.dev/npm/package/rdme/files/8.6.5-next.2/bin/docker.js/issues/T167-182)
* typo ([#852](#852)) ([26c10e5](26c10e5))
* **versions:** general refactors to handle flag edge cases ([#861](#861)) ([e316139](e316139))

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta kanadgupta approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @kanadgupta