ci: prettier, drop node 19 #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
approved these changes
Aug 14, 2023
kanadgupta
commented
Aug 14, 2023
Comment on lines
+30
to
+35
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - run: npm ci | ||
| - run: npm run lint |
There was a problem hiding this comment.
since lint-docs.yml had the same triggers as ci.yml, i just deleted the former and combined it with the latter
| - name: Install deps | ||
| run: npm ci | ||
| - name: Install deps and run tests | ||
| run: npm cit |
There was a problem hiding this comment.
our build script now runs via a pretest hook
kanadgupta
changed the title
kanadgupta
added
enhancement
erunion
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Slightly reorganizes our lint/CI workflows to run
prettieragainst everything. Also drops tests against Node 19.🧬 QA & Testing
Do tests pass?